[Pkg-samba-maint] filtering on dh_listpackages in d/rules

[Mathieu Parent]

On Tue, Apr 5, 2022 at 5:13 PM Michael Tokarev <mjt at tls.msk.ru> wrote:
>
> In d/rules we have several places which checks if certain packages are
> in the dh_listpackages list (initially was inlined, I changed that to cached).
>
> I wonder where this list can be different to start with. Might this be
> the following fragment in d/rules:
>
> # Ubuntu i386 binary compatibility only effort: Disable some i386 packages
> ifeq ($(DEB_VENDOR) $(DEB_HOST_ARCH), Ubuntu i386)
>          BUILD_PACKAGES += \
>                  -Nctdb \
>                  -Nlibpam-winbind \
>                  -Nsamba \
>                  -Nsamba-testsuite
> endif
>
> so that subsequent tests which referred to dh_listpackages were supposed
> to depend on this -N list?
>
> This is kinda twisted with the dh sequence.
>
> %:
>          dh $* --with python3 $(BUILD_PACKAGES)
>
> So first we run d/rules which is parsed with full list of the
> packages in dh_listpackages. But this does nothing, since we
> just run dh $foo.  Which now gets the right -N thing, -- every
> dh step does. So dh run ./d/rules again to perform some small
> steps given by override_dh_foo. Parsing d/rules again. And
> hopefully this time, we have it return a different list,
> which now takes into account these -N arguments.  Note the
> dh_listpackages call is _not_ done with these args, - I
> suppose it is saved somewhere in the environment maybe so
> all dh_foo tools knows about it.. or not?  Hmm...
>
> At any rate this is definitely not obvious.

Debian derivatives sometimes ship only a subset of packages. This is
the case for Ubuntu i386.

Maybe the code can be improved as you said.


-- 
Mathieu