[Pkg-samba-maint] Profiling support in 2:4.16.1+dfsg-5

[Michael Tokarev]

01.06.2022 21:01, Andreas Hasenack wrote:
> Hi,

Hello Andreas!

> I see profiling support was enabled, and was wondering if there is any
> fear this might introduce performance regressions. I didn't find much
> about it, just some data[1] from ancient samba 2.2.1 when it was first
> introduced, which said:

Well. I haven't seriously measured performance after enabling profiling.
I did quite some basic tests, - like copying large files back and forth
and copying a lot of small files also back and forth between windows 10
client and a linux server.  Just a basic test, measuring speed of the
same operation with and without profiling support compiled in.  I haven't
noticed any difference, everything was within measurement error, even
more: the configuration *with* profiling seemed just a very little bit
faster than without, - again, still within a measurement error.
But I don't have fastest setup here. It is GigE but definitely not the
fastest SSDs.

Someone from the samba team said profiling effect on performance should
be negligible, if not actually enabled during runtime.  Other people said
they didn't notice any difference even after enabling profiling.

As Louis van Belle (he provided builds of more recent samba versions for
various debian releases) put it:

  Some monitoring tools need the option in d/rules --with-profiling-data
  https://learn.netdata.cloud/docs/agent/collectors/python.d.plugin/samba/

  https://packages.debian.org/bullseye/netdata

I just thought I'd give it a try, that's it.

Thanks,

/mjt