[Pkg-samba-maint] Bug#1006863: tevent: reproducible-builds: build path embedded in various libraries

[Vagrant Cascadian]

On 2022-03-07, Andrew Bartlett wrote:
> I would rather this be discussed and implemented upstream.
>
> For one, the tevent build system is shared with the rest of Samba, and
> if possible this should be implemented by default for all 'make
> install' runs, just as we do to strip out the bin/default from -rpath.

Originally reported as https://bugs.debian.org/1006863 where I proposed
passing additional arguments via CFLAGS in the debian build system.

Attached is a proof of concept patch that works by adding the argument
to CFLAGS by patching the upstream buildsystem.

The patch is bit ugly in how it derives the top level source directory
and likely error-prone... a cleaner way of going about that would be
much appreciated!

It also requires gcc 8+ or clang 10+ ... making it detect weather the
argument was supported and only adding it conditionally might be
desireable.

I am not too familiar with samba project processes, let me know if
there's a better place to send this!


live well,
  vagrant

> On Sun, 2022-03-06 at 16:43 -0800, Vagrant Cascadian wrote:
>> Source: tevent
>> Severity: normal
>> Tags: patch
>> User: reproducible-builds at lists.alioth.debian.org
>> Usertags: buildpath
>> X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org
>> 
>> The build path and resulting Build ID for various libraries is
>> embedded:
>> 
>>   
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/tevent.html
>> 
>>   /usr/lib/x86_64-linux-gnu/libtevent.so.0.11.0
>> 
>>   /build/1st/tevent-0.11.0/bin/default/../../tevent.c:303
>>   vs.
>>   /build/2/tevent-0.11.0/2nd/bin/default/../../tevent.c:303
>> 
>> The attached patch to debian/rules fixes this by passing
>> -ffile-prefix-map via CFLAGS in the dh_auto_configure override.
>> 
>> Alternately, updating to use the CFLAGS passed via dh/debhelper would
>> also likely fix this.
>> 
>> With this patch applied tevent should build reproducibly on
>> tests.reproducible-builds.org!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-buildtools-wafsamba-samba_autoconf.py-Add-ffile-pref.patch
Type: text/x-diff
Size: 1351 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-samba-maint/attachments/20220312/58099fc3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-samba-maint/attachments/20220312/58099fc3/attachment.sig>