[Pkg-samba-maint] Bug#1006875: samba-libs: The dependency on python3-talloc breaks multiarch support

[Andrew Bartlett]

On Thu, 2022-03-31 at 18:54 +0300, Michael Tokarev wrote:
> On Mon, 07 Mar 2022 12:01:43 +0100 Francois Gouget <fgouget at free.fr>
> wrote:
> > Package: samba-libs
> > Version: 2:4.13.13+dfsg-1~deb11u2
> > Severity: normal
> > 
> > Dear Maintainer,
> > 
> > samba-libs claims to support multiarch (Multiarch: same) but it
> > depends
> > on python3-talloc which does not support multiarch.
> > 
> > python3-talloc seems to depend closely on the main python3 package
> > so
> > I am not sure it would make sense to make it multiarch. So maybe it
> > is
> > samba-libs that should not depend on it. Could the dependency be
> > moved
> > to another package which would be, for instance, multiarch=foreign?
> 
> I wonder why samba-libs does depend on python3-anything to start
> with.
> It looks like this should not be the case.
> 
> All python-related files has been in a separate package, python3-
> samba,
> and that one rightfully depends on python3-talloc python3-ldb and
> some
> others.  But samba-libs, apparently, supposed to be without python
> modules..
> 
> $ dpkg -L samba-libs | grep python
> /usr/lib/x86_64-linux-gnu/libsamba-policy.cpython-39-x86-64-linux-
> gnu.so.0.0.1
> /usr/lib/x86_64-linux-gnu/libsamba-policy.cpython-39-x86-64-linux-
> gnu.so.0
> /usr/lib/x86_64-linux-gnu/samba/libsamba-net.cpython-39-x86-64-linux-
> gnu-samba4.so.0
> /usr/lib/x86_64-linux-gnu/samba/libsamba-python.cpython-39-x86-64-
> linux-gnu-samba4.so.0
> 
> I wonder if we should move this one into python3-samba package?
> 
> And it seems this to be the case for a very long time, this
> particular python module has always been in samba-libs pkg
> instead of python3-samba package. Apparently forgotten when
> the python samba package has been created.
> 
> ..I did an experiment, and it looks like it worked fine. So
> I'll include this file move in the upcoming 4.16 release.

Samba's libsamba-net.cpython-38-x86-64-linux-gnu-samba4.so is indeed a
normal library linked to by other bits of Samba that links to python
(it opens python modules and runs them). 

With some work that could possibly be removed for a production build,
the use case ends up only being smbtorture, but currently it is the
case. 

So moving those around would not change the resulting dependencies
unless one was very careful. 

Andrew Bartlett

-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead, Catalyst IT   https://catalyst.net.nz/services/samba

Samba Development and Support, Catalyst IT - Expert Open Source
Solutions