[Pkg-samba-maint] sambashare group and enabling usershares by default

Mathieu Parent math.parent at gmail.com
Tue May 3 16:17:11 BST 2022


hello,

On Tue, May 3, 2022 at 4:46 PM Michael Tokarev <mjt at tls.msk.ru> wrote:
>
> In debian, samba package carries a patch which enables user shares
> by default. I don't know why this was made this way, - usershares
> are an additional potential for security issues, and they're not
> actually as widely used.  We have to explicitly disable then
> (usershare max shares = 0) on every samba install.

This changes comes from Ubuntu initially. CCing some of the latest uploaders.

If I recall correctly this option is needed for proper integration of
Samba share in Gnome.
I think this feature is useful for desktop users, but not for servers.

Anyway, I think diverging from upstream Samba here is not good. So
removing this patch is OK for me.

> I'd love to get rid of this change. This warrants a NEWS entry
> ofcourse, because this has a high potential for breaking users
> config. This is not a problem per se.
>
> There's also an interesting twist about sambashare group and
> the default path for usershares set to /var/lib/samba/usershares/ -
> this group and this directory are created on every upgrade of
> the samba package, even if the administrator explicitly removed
> them before. I think this should be guarded with !upgrade.

OK for this.

> What do you think?
>
> Thanks,
>
> /mjt
>
> _______________________________________________
> Pkg-samba-maint mailing list
> Pkg-samba-maint at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-samba-maint



-- 
Mathieu



More information about the Pkg-samba-maint mailing list