[Pkg-samba-maint] Bug#941930: smbclient: protocol negotiation failed: NT_STATUS_INVALID_PARAMETER_MIX with maxprotocol=NT1

[Michael Tokarev]

Control: tag -1 + confirmed upstream
Control: found -1 2:4.17.2+dfsg-1
Control: found -1 2:4.16.6+dfsg-2

On Mon, 07 Oct 2019 19:13:12 +0200 luca <agoiza at gmail.com> wrote:
> Package: smbclient
> Version: 2:4.11.0+dfsg-10
> Severity: normal
> 
> Dear Maintainer,
> 
> after update in testing of samba pkgs version 2:4.11.0+dfsg-10 maxprotocol=NT1
> seems no more working as aspected
> 
> ----------------------------------------------------------------------
> $ smbclient \\\\192.168.0.101\\tmp
> Unable to initialize messaging context
> Enter BDEV\ilprof's password:
> Try "help" to get a list of possible commands.
> smb: \>
> ----------------------------------------------------------------------
> 
> but with maxprotocol=NT1
> 
> ----------------------------------------------------------------------
> $ smbclient \\\\192.168.0.101\\tmp -m NT1
> Unable to initialize messaging context
> protocol negotiation failed: NT_STATUS_INVALID_PARAMETER_MIX
> ----------------------------------------------------------------------

This seems to be a problem with command-line parameter parsing of smbclient,
or parameter logic.

In man smb.conf, there's "client min protocol" parameter, which is SMB2_02
in current version (4.16) of samba.  And smbclient has its own option,
-m, or --max-protocol, which is used here.

It looks like smbclient *might* error out at least in case min protocol is
larger than the specified max protocol.  Or better yet, fix min protocol to
be the same as max protocol in this case (unless it is explicitly set in
the smb.conf file).

In order for smbclient to actually use NT1 protocol, one have to also specify
"client min prococol = NT1" - either in smb.conf or in additional --option
command-line option.

I dunno why upstream did it this way - either by design, or it wasn't intended
to be this way.

Let's ask upstream..

/mjt