[Pkg-samba-maint] [Git][samba-team/samba][master] d/rules: add comment about -latomic gcc issue and drop --as-needed there since it is already in use

[Michael Tokarev (@mjt)]

Michael Tokarev pushed to branch master at Debian Samba Team / samba


Commits:
e71db6b9 by Michael Tokarev at 2023-07-09T09:56:43+03:00
d/rules: add comment about -latomic gcc issue and drop --as-needed there since it is already in use

- - - - -


1 changed file:

- debian/rules


Changes:

=====================================
debian/rules
=====================================
@@ -105,15 +105,17 @@ with-glusterfs =
 endif
 
 ifneq (,$(filter armel mipsel m68k powerpc sh4,${DEB_HOST_ARCH}))
-# for some reason these platforms fail to find __atomic_{load,store}_8
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81358
+# on these platforms gcc does not link with -latomic, resulting in
 #   third_party/heimdal/lib/krb5/krcache.c.55.o: in function `krcc_get_principal':
 #   third_party/heimdal/lib/krb5/krcache.c:1395: undefined reference to `__atomic_load_8'
 #     ids.krcu_cache_and_princ_id = heim_base_atomic_load(&data->krc_cache_and_principal_id);
 #   third_party/heimdal/lib/base/heimbase-atomics.h:
 #     #include <stdatomic.h>
 #     #define heim_base_atomic_load(x)        atomic_load((x))
-# include a rough workaround for now (-latomic and <stdatomic.h> comes from gcc)
-LDFLAGS := ${LDFLAGS} -Wl,--as-needed -latomic
+# include a workaround for now
+# (-latomic and <stdatomic.h> comes from gcc, --as-needed is already in use)
+LDFLAGS := ${LDFLAGS} -latomic
 endif
 
 config-args += $(if ${with-ceph},\



View it on GitLab: https://salsa.debian.org/samba-team/samba/-/commit/e71db6b974e8826c18c943548f7ca519db951947

-- 
View it on GitLab: https://salsa.debian.org/samba-team/samba/-/commit/e71db6b974e8826c18c943548f7ca519db951947
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-samba-maint/attachments/20230709/b6b3dacb/attachment-0001.htm>