[Pkg-samba-maint] Bug#1065188: samba: missing build-dep on libtirpc-dev (and also rpcsvc-proto)

[Aurelien Jarno]

Source: samba
Version: 2:12.3.5-4
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)
User: debian-glibc at lists.debian.org
Usertags: libtirpc-dev

Dear maintainer,

Starting with glibc 2.31, support for NIS (libnsl library) has been
moved to a separate libnsl2 package. In order to allow a smooth
transition, a libnsl-dev, which depends on libtirpc-dev, has been added
to the libc6-dev package.

The libnsl-dev dependency has been temporarily dropped in the 2.37-15.1
NMU, as part of the 64-bit time_t transition. This causes samba to
FTBFS in sid with:

| [4938/6301] Compiling ctdb/utils/smnotify/smnotify.c
| 13:58:50 runner ['x86_64-linux-gnu-gcc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1', '-g', '-O2', '-ffile-prefix-map=/<<PKGBUILDDIR>>=.', '-fstack-protector-strong', '-fstack-clash-protection', '-Wformat', '-Werror=format-security', '-fcf-protection', '-ffile-prefix-map=../../=', '-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1', '-DHAVE_CONFIG_H=1', '-fPIE', '-fPIC', '-D__STDC_WANT_LIB_EXT1__=1', '-D_REENTRANT', '-DCTDB_HELPER_BINDIR="/usr/libexec/ctdb"', '-DLOGDIR="/var/log/ctdb"', '-DCTDB_DATADIR="/usr/share/ctdb"', '-DCTDB_ETCDIR="/etc/ctdb"', '-DCTDB_VARDIR="/var/lib/ctdb"', '-DCTDB_RUNDIR="/run/ctdb"', '-fstack-protector-strong', '-fstack-clash-protection', '-DSTATIC_smnotify_MODULES=NULL', '-DSTATIC_smnotify_MODULES_PROTO=extern void __smnotify_dummy_module_proto(void)', '-Ictdb', '-I../../ctdb', '-Ictdb/utils', '-I../../ctdb/utils', '-Ictdb/utils/smnotify', '-I../../ctdb/utils/smnotify', '-Iinclude/public', '-I../../include/public', '-Isource4', '-I../../source4', '-Ilib', '-I../../lib', '-Isource4/lib', '-I../../source4/lib', '-Isource4/include', '-I../../source4/include', '-Iinclude', '-I../../include', '-Ilib/replace', '-I../../lib/replace', '-Ictdb/include', '-I../../ctdb/include', '-I.', '-I../..', '../../ctdb/utils/smnotify/smnotify.c', '-c', '-o/<<PKGBUILDDIR>>/bin/default/ctdb/utils/smnotify/smnotify.c.54.o', '-Wdate-time', '-D_FORTIFY_SOURCE=2']
| [4939/6301] Linking bin/default/ctdb/ctdb_takeover_helper.inst
| 13:58:50 runner ['x86_64-linux-gnu-gcc', '-Wl,--as-needed', 'ctdb/protocol/protocol_header.c.7.o', 'ctdb/protocol/protocol_packet.c.7.o', 'ctdb/protocol/protocol_types.c.7.o', 'ctdb/protocol/protocol_call.c.7.o', 'ctdb/protocol/protocol_message.c.7.o', 'ctdb/protocol/protocol_control.c.7.o', 'ctdb/protocol/protocol_keepalive.c.7.o', 'ctdb/protocol/protocol_tunnel.c.7.o', 'ctdb/protocol/protocol_client.c.7.o', 'ctdb/protocol/protocol_debug.c.7.o', 'ctdb/protocol/protocol_sock.c.7.o', 'ctdb/server/ipalloc_deterministic.c.11.o', 'ctdb/server/ipalloc_nondeterministic.c.11.o', 'ctdb/server/ipalloc_lcp2.c.11.o', 'ctdb/server/ipalloc_common.c.11.o', 'ctdb/server/ipalloc.c.11.o', 'ctdb/protocol/protocol_basic.c.6.o', 'ctdb/server/ctdb_takeover_helper.c.47.o', 'ctdb/common/cmdline.c.4.o', 'ctdb/common/comm.c.4.o', 'ctdb/common/conf.c.4.o', 'ctdb/common/db_hash.c.4.o', 'ctdb/common/event_script.c.4.o', 'ctdb/common/hash_count.c.4.o', 'ctdb/common/line.c.4.o', 'ctdb/common/logging.c.4.o', 'ctdb/common/path.c.4.o', 'ctdb/common/pidfile.c.4.o', 'ctdb/common/pkt_read.c.4.o', 'ctdb/common/pkt_write.c.4.o', 'ctdb/common/rb_tree.c.4.o', 'ctdb/common/reqid.c.4.o', 'ctdb/common/run_event.c.4.o', 'ctdb/common/run_proc.c.4.o', 'ctdb/common/sock_client.c.4.o', 'ctdb/common/srvid.c.4.o', 'ctdb/common/tmon.c.4.o', 'ctdb/common/tunable.c.4.o', 'lib/async_req/async_sock.c.1.o', 'ctdb/protocol/protocol_util.c.8.o', 'ctdb/client/client_connect.c.9.o', 'ctdb/client/client_call.c.9.o', 'ctdb/client/client_message.c.9.o', 'ctdb/client/client_control.c.9.o', 'ctdb/client/client_message_sync.c.9.o', 'ctdb/client/client_control_sync.c.9.o', 'ctdb/client/client_db.c.9.o', 'ctdb/client/client_util.c.9.o', 'ctdb/client/client_tunnel.c.9.o', '-o/<<PKGBUILDDIR>>/bin/default/ctdb/ctdb_takeover_helper.inst', '-Wl,-rpath,/usr/lib/x86_64-linux-gnu/samba', '-Wl,-Bstatic', '-Wl,-Bdynamic', '-L/<<PKGBUILDDIR>>/bin/default/libcli/util', '-L/<<PKGBUILDDIR>>/bin/default/lib/tdb_wrap', '-L/<<PKGBUILDDIR>>/bin/default/lib/util', '-L/<<PKGBUILDDIR>>/bin/default/lib/replace', '-L/usr/local/lib', '-L/usr/local/lib', '-lreplace-samba4', '-lsocket-blocking-samba4', '-lsys-rw-samba4', '-lsamba-util', '-liov-buf-samba4', '-ltdb-wrap-samba4', '-ltevent-util', '-lutil-setid-samba4', '-ltime-basic-samba4', '-lgenrand-samba4', '-lsamba-debug-samba4', '-lsamba-errors', '-licuuc', '-licui18n', '-licudata', '-lsystemd', '-lgnutls', '-lpopt', '-lbsd', '-ltevent', '-ltalloc', '-ltdb', '-ltalloc', '-Wl,-z,relro', '-Wl,-z,now', '-pie', '-Wl,-z,relro,-z,now', '-Wl,-no-undefined', '-Wl,--export-dynamic']
| In file included from ../../ctdb/utils/smnotify/smnotify.c:27:
| ctdb/utils/smnotify/smnotify.h:9:10: fatal error: rpc/rpc.h: No such file or directory
|     9 | #include <rpc/rpc.h>
|       |          ^~~~~~~~~~~
| compilation terminated.
 
This could be fixed by adding an explicit Build-Depends on libtirpc-dev.
The glibc change will likely be reverted in the short term, but given
its a change we want to do for Trixie, this will only lower the severity
of the bug.
 
I also noticed that samba, uses rpcgen, provided by the rpcsvc-proto
during the build process. It is currently a depends of the libc6-dev
package for the same reason as libnsl-dev, and will be removed at some
point. Therefore please also add an explicit Build-Depends on
rpcsvc-proto.
 
Regards
Aurelien