[Pkg-samba-maint] Bug#1065349: Bug#1065349: libsmbclient0: Actually breaks part of t64 transition

[Eric Valette]

On 03/03/2024 14:50, Michael Tokarev wrote:
> Control: severity -1 important
> 
> 03.03.2024 13:21, Eric Valette :
>> Package: libsmbclient0
>> Version: 2:4.19.5+dfsg-3
>> Severity: grave
>> Justification: renders package unusable
> 
> This is wrong, in my opinion.  The effect of this bug on platforms 
> unaffected
> by time64_t transition is exactly the same as on platforms affected by the
> transition.


apt download libsmbclient0
Réception de :1 http://ftp.de.debian.org/debian unstable/main amd64 
libsmbclient0 amd64 2:4.19.5+dfsg-3 [86,5 kB]
86,5 ko réceptionnés en 0s (418 ko/s)
valette at tri-yann5:/tmp$ dpkg-deb -R 
libsmbclient0_2%3a4.19.5+dfsg-3_amd64.deb libsmbclient
valette at tri-yann5:/tmp$ cd libsmbclient/
valette at tri-yann5:/tmp/libsmbclient$ more DEBIAN/control
Package: libsmbclient0
Source: samba
Version: 2:4.19.5+dfsg-3
Architecture: amd64
Maintainer: Debian Samba Maintainers 
<pkg-samba-maint at lists.alioth.debian.org>
Installed-Size: 240
Depends: samba-libs (= 2:4.19.5+dfsg-3), libbsd0 (>= 0.0), libc6 (>= 
2.25), libndr3 (>= 2:4.17.2), libtalloc2 (>= 2.4.1~), libtevent0t64 (>= 
0.15.0)
Breaks: libsmbclient (<< 2:4.19.5+dfsg-3)
Replaces: libsmbclient
Section: libs
Priority: optional
Multi-Arch: same
Homepage: https://www.samba.org
Description: shared library for communication with SMB/CIFS servers
  This package provides a shared library that enables client applications
  to talk to Microsoft Windows and Samba servers using the SMB/CIFS
  protocol.


So Although I'm not a debian developer, I read this control file as:

You cannot install libsmbclient0 without breaking libsmbclient if the 
version of libsmbclient is not at least 2:4.19.5+dfsg-3. It will then 
replace libsmbclient.

BUT the package libsmbclient 2:4.19.5+dfsg-3 is never going to be 
generated nor latter versions unless the names change back to 
libsmbclient. So the condition will never happen.

The Provides directive give a way to provide libsmbclient  2:4.19.5+dfsg-3

And as you state, if the time_t type is already 64 bits why should 
package depending on libsmbclient need to be regenerated?


--eric