[Pkg-samba-maint] Bug#1085617: Bug#1085617: samba package has obsolete file /etc/init.d/samba-ad-dc

[Michael Tokarev]

Control: severity -1 minor
Control: tag -1 + confirmed

21.10.2024 12:22, richardn wrote:
> Package: samba
> Version: 2:4.21.1+dfsg-1
> Severity: normal
> X-Debbugs-Cc: richardn26 at gmail.com
> 
> System has samba package version 2:4.21.1+dfsg-1 installed, but does not have samba-ad-dc installed.
> 
> System still has the file
> 
> /etc/init.d/samba-ad-dc
> 
> which looks as though it should have been moved to the samba-ad-dc package

Yes, the initscript has been moved to samba-ad-dc package.

However, removing these files (initscript and the links) is a bit of a challenge,
that's why I left them hanging there.  Maybe I should rethink this because..

> (I noticed this because systemd has started nagging
> 
> systemd-sysv-generator[57646]: SysV service '/etc/init.d/samba-ad-dc' lacks a native systemd unit file. ~ Automatically generating a unit file for compatibility. Please update package to include a native systemd unit file, in order to make it safe, robust and future-proof. ! This compatibility logic is deprecated, expect removal soon. !

..because of this - I didn't think of systemd complaining.

Presence of the initscript is entirely harmless, since it checks
if the executable is there and does nothing if it is not (and the
executable is now part of samba-ad-dc).  But systemd adds more
noise into the mix.  Either way it is harmless still.

> Perhaps this should be fixed in the samba-ad-dc package too)

There's nothing to fix in samba-ad-dc package, -- besides maybe
removing references of this initscript from samba package.

An alternative would be to drop all the initscripts entirely,
which isn't bad at all.

/mjt