[Pkg-samba-maint] Bug#1080347: moving samba-tool to python3-samba is a breaking change - please re-open bug

[Michael Tokarev]

02.09.2024 23:09, Jürgen Pfennig wrote:
> Hello Michael

Hello!

> (1) samba-tool is a tool that is used at the client side, why do you talk
>      of samba-ad-dc?

Well.  It is not me who talked about setting up an AD-DC environment.
I did't say samba-tool is part of samba-ad-dc, I wrote that to set up
AD-DC with samba, you need samba-ad-dc package.  This (moving ad-dc-
related things to a separate package) *is* a breaking change and it
is documented in the NEWS file and will be documented in the trixie
release note too (once it's out).

> (2) it is not part of samba-ad-dc

samba-tool will definitely be installed if you install samba-ad-dc.

> (3) moving the tool to a different package is a change that breaks
>      installations

It is not.  Before, samba has always had Depends: pythoin3-samba
(where it is now), so at upgrade, you'll always have samba-tool
installed (since python3-samba wont be removed but upgraded).
So it definitely will not break an existing installation.

For new installs, you may notice that samba package Recommend:s
python3-samba, so it will be installed too with default settings
(which is to install recommends).  So it will not break new
installation either.

The only case where this changes anything is when the user
explicitly disables installing recommended packages.  And for
this case, it is a) not guaranteed to work for obvious reasons
(since optional dependencies might not be installed and hence
parts of a package might become non-working), and b) it is
expected from the user to do their (simple) homework.

What I can do is to add another NEWS item for samba package
about moving samba-tool to python3-samba.  But this wont help
for the new installs (since in this case NEWS items aren't
displayed, again for a good reason), but will annoy most
users when upgrading, since most users it is irrelevant
anyway.

> why didn't you simply answer my bug-report by saying:
>      samba-tool has been moved to python3-samba

Well.  Because it is not the question you asked.  Or not
the ONLY question.  Because you were asking about setting
an AD-DC, not just about samba-tool, and for AD-DC, the
answer is to install samba-ad-dc package, which is mentioned
in the NEWS.

Please note: in order to join a samba machine to an existing
(samba or not) AD-DC domain, samba-tool isn't even required, -
`net ads join` works too.

The whole change (rearrangement of files) has been done after
a demand from users who wanted to have much smaller setup
with samba (especially on smaller machines), and noticed that
quite some stuff isn't required for a regular stand-alone file
server.  And I managed to perform such move in a non-breaking
way (the (3) above).

You can re-open this bug report yourself if you want (as you're
asking in the subject line).  But a) it is not true (re breaking),
and b) there's nothing else I can do with it besides mark it
as "wontfix", after which it will stay here forever for no reason
whatsoever (only to make my work a little more harder).  Or do
you have other suggestions?  Maybe to move things back?

Thanks,

/mjt