[Pkg-samba-maint] [Git][samba-team/samba][master] 3 commits: debian/panic-action: steer users towards configuration and logs

[Michael Tokarev (@mjt)]

Michael Tokarev pushed to branch master at Debian Samba Team / samba


Commits:
9d932950 by Douglas Bagnall at 2025-02-07T11:55:40+13:00
debian/panic-action: steer users towards configuration and logs

In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1089853, a
misconfiuration was mistaken for a segmentation fault, even after the
reporter found the panic could be avoided by fixing the configuration.

This is likely because the message mentions "segfault" and produces
only a stacktrace as diagnostic evidence, which is enough to fool
anyone.

The smb_panic() call itself knows more, because it is given a message
(in this case "open_sockets_smbd() failed", which may not help), and
this is logged, as usually are a number of preceding related messages.

We could with some effort allow the panic action to take a message in
$2, but this will be a bit fiddly as we would need to move away from
using system() to avoid shell escaping trouble.

Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

- - - - -
63b2dff1 by Douglas Bagnall at 2025-02-07T12:11:39+13:00
debian/panic-action: don't say "you" when "I" is meant

Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

- - - - -
0862d1ef by Michael Tokarev at 2025-07-11T12:08:05+03:00
Merge branch 'dbagnall-debian-master-panic-action' into 'master'

debian/panic-action: steer users towards configuration and logs

See merge request samba-team/samba!65
- - - - -


1 changed file:

- debian/panic-action


Changes:

=====================================
debian/panic-action
=====================================
@@ -24,12 +24,14 @@ type mail >/dev/null 2>&1 || exit 0
 	echo "was called for PID $1 ($BINARYNAME)."
 	echo
 
-	echo "This means there was a problem with the program, such as a segfault."
+	echo "This means the program found itself in a state from which it could not continue."
+	echo "It could be caused by misconfiguration, a segfault, memory allocation failure,"
+	echo "data corruption, or some other problem."
 
 	if [ -z "$BINARYNAME" ]; then
 		echo "However, the executable could not be found for process $1."
-		echo "It may have died unexpectedly, or you may not have permission to debug"
-		echo "the process."
+		echo "It may have died unexpectedly, or this script may not have permission to"
+		echo "debug the process."
 		exit 1
 	fi
 
@@ -43,7 +45,7 @@ type mail >/dev/null 2>&1 || exit 0
 
 	echo "Below is a backtrace for this process generated with gdb, which shows"
 	echo "the state of the program at the time the error occurred.  The Samba log"
-	echo "files may contain additional information about the problem."
+	echo "files should contain additional information about the problem."
 	echo 
 	echo "If the problem persists, you are encouraged to first install the"
 	echo "samba-dbgsym package, which contains the debugging symbols for the Samba"



View it on GitLab: https://salsa.debian.org/samba-team/samba/-/compare/b725f36ca00cf81c7562a869ac9688d876f81553...0862d1efe9e49445de961a02c4d90b37738f411f

-- 
View it on GitLab: https://salsa.debian.org/samba-team/samba/-/compare/b725f36ca00cf81c7562a869ac9688d876f81553...0862d1efe9e49445de961a02c4d90b37738f411f
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-samba-maint/attachments/20250711/f8197116/attachment-0001.htm>