[Pkg-samba-maint] [Git][samba-team/samba][debian/4.24] 35 commits: VERSION: Bump version up to Samba 4.24.8...
Michael Tokarev (@mjt)
gitlab at salsa.debian.org
Wed Oct 14 08:08:13 BST 2026
Michael Tokarev pushed to branch debian/4.24 at Debian Samba Team / samba
Commits:
b94a5bee by Björn Jacke at 2026-09-09T17:09:50+02:00
VERSION: Bump version up to Samba 4.24.8...
and re-enable GIT_SNAPSHOT.
Signed-off-by: Bjoern Jacke <bjacke at samba.org>
- - - - -
8c70a5fc by Stefan Metzmacher at 2026-09-14T18:47:19+00:00
libcli/smb: add smb2cli_session_check_reauth() helper
That checks that the last session setup response of a reauth
is correctly signed by the server.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15962
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit 2df8022bdc82e216973d8037e053821fe97c224a)
- - - - -
6d446f6d by Stefan Metzmacher at 2026-09-14T18:47:19+00:00
s3:torture: let SMB2-SESSION_REAUTH use smb2cli_session_check_reauth()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15962
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit 4ecb6b83e55bfb62440c1b309bbaa18fd19bb202)
- - - - -
790f544e by Stefan Metzmacher at 2026-09-14T18:47:19+00:00
s4:libcli/smb2: let smb2_session_setup_spnego_both_ready() call smb2cli_session_check_reauth()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15962
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit 5f0a2fec20fa71ccd75bb3d9aaa92cd1233a60db)
- - - - -
1f857683 by Stefan Metzmacher at 2026-09-14T18:47:19+00:00
s4:torture/smb2: There's no need to use smb2cli_session_require_signed_response()
This is now handled by smb2cli_session_check_reauth().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15962
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit 8ae9253241c311fa3bbe65a98a8c97d9ec0c649b)
- - - - -
3d9dff69 by Stefan Metzmacher at 2026-09-14T18:47:19+00:00
libcli/smb: don't reset state->smb2.require_signed_response without NT_STATUS_OK
We no longer use this for reauth tests, so that reset is no longer
needed.
We could remove smb2cli_session_require_signed_response() completely,
but I think it can be useful for other tests in future.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15962
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit f6790404d6fa04d438b952b6b8f908b6ab4f5d9b)
- - - - -
a422fae4 by Stefan Metzmacher at 2026-09-14T18:47:19+00:00
s3:smb2_server: make it possible to sign responses even with encryption
Final session setup responses should always be signed, even if
they are wrapped with encryption.
This fixed setups where encryption is required and
a session is expired.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15962
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Sep 11 17:38:18 UTC 2026 on atb-devel-224
(cherry picked from commit 235658e3ecc1d971e7f963edbeba828748871d1c)
- - - - -
9e347e1f by Kopylov Pavel at 2026-09-14T18:47:19+00:00
lib:param: Fix uppercase "0X" prefix in kdc default domain enctypes
handle_kdc_default_domain_supported_enctypes() decides whether an
enctype token is written in hexadecimal by looking for a leading
"0x" / "0X". The test contained a typo:
if (bitstr[0] == '0' &&
(bitstr[1] == 'x' || bitstr[2] == 'X'))
The second comparison indexes bitstr[2] instead of bitstr[1]. Two
consequences follow:
* A value written with an uppercase prefix, e.g. "0X1F", is not
recognised as hexadecimal. It is then parsed with base 10 using
smb_strtoul(..., SMB_STR_FULL_STR_CONV), which fails on the "X" and
the whole value is rejected with a warning and silently dropped.
Lowercase "0x1f" happened to work only by accident.
* For a bare "0" token, bitstr[1] is the NUL terminator, so the
short-circuit falls through to bitstr[2], a one-byte read past the
end of the two-byte buffer "0\0" (out-of-bounds read).
Compare bitstr[1] against 'X' as intended. This makes uppercase hex
values work and removes the out-of-bounds read. The value is parsed from
admin-controlled smb.conf, so there is no remote exposure.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16239
RN: Fix parsing of uppercase "0X" hex values in the "kdc default domain
supported enctypes" smb.conf parameter.
Signed-off-by: Kopylov Pavel <pkopylov at cloudlinux.com>
Reviewed-by: Jennifer Sutton <jennifersutton at catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit 608afbe571a6314adfd191e2b069ac3ff66f7c93)
- - - - -
bf24b4c8 by Kopylov Pavel at 2026-09-14T18:47:19+00:00
lib:param: Fix uppercase "0X" prefix in kdc supported enctypes
handle_kdc_supported_enctypes() carries the same typo the previous
commit fixed in handle_kdc_default_domain_supported_enctypes():
if (bitstr[0] == '0' &&
(bitstr[1] == 'x' || bitstr[2] == 'X'))
The second comparison indexes bitstr[2] instead of bitstr[1], with the
same two consequences:
* A value written with an uppercase prefix, e.g. "0X1C", is not
recognised as hexadecimal. It is then parsed with base 10 using
smb_strtoul(..., SMB_STR_FULL_STR_CONV), which fails on the "X" and
the whole value is rejected with a warning and silently dropped.
Lowercase "0x1c" happened to work only by accident.
* For a bare "0" token, bitstr[1] is the NUL terminator, so the
short-circuit falls through to bitstr[2], reading one byte past the
end of the string allocated by str_list_make(). valgrind on
"kdc supported enctypes = 0" reports:
Invalid read of size 1
at handle_kdc_supported_enctypes (loadparm.c:1931)
by set_variable (loadparm.c:1969)
by lpcfg_do_global_parameter (loadparm.c:2028)
Address 0x939cd52 is 0 bytes after a block of size 98 alloc'd
by talloc_strndup (talloc.c:2479)
by str_list_make (util_strlist.c:101)
by handle_kdc_supported_enctypes (loadparm.c:1899)
Compare bitstr[1] against 'X' as intended. This makes uppercase hex
values work and removes the out-of-bounds read. The value is parsed from
admin-controlled smb.conf, so there is no remote exposure.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16239
RN: Fix parsing of uppercase "0X" hex values in the "kdc supported
enctypes" smb.conf parameter.
Signed-off-by: Kopylov Pavel <pkopylov at cloudlinux.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
Reviewed-by: Jennifer Sutton <jennifersutton at catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit 27c87a723ba3e2e9d36df8736641d3c191bf4aa2)
- - - - -
75977729 by Kopylov Pavel at 2026-09-14T18:47:19+00:00
tests/param: Test hex and decimal enctype bitmask parsing
Cover both "kdc supported enctypes" and "kdc default domain supported
enctypes" with lowercase and uppercase "0x" / "0X" prefixes. The
uppercase spellings were rejected outright before the preceding two
commits.
The bare "0" cases exercise the token that made the old code read past
the end of the string. They pass either way in a plain build and only
fail under a memory checker, but keep that input covered.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16239
Signed-off-by: Kopylov Pavel <pkopylov at cloudlinux.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
Reviewed-by: Jennifer Sutton <jennifersutton at catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit a1979f9b976a9f0f0505068ce2b4fa057eb7072c)
- - - - -
bb20b83d by Kopylov Pavel at 2026-09-14T18:47:19+00:00
lib:param: Log the right parameter in handle_kdc_supported_enctypes()
The warning emitted for an unparsable token names "kdc default domain
supported enctypes", the parameter handled by the neighbouring
handle_kdc_default_domain_supported_enctypes(). An admin with a bad
value in "kdc supported enctypes" is pointed at the wrong smb.conf
line:
handle_kdc_supported_enctypes: WARNING: Ignoring invalid value '0Xzz'
for parameter 'kdc default domain supported enctypes'
Name the parameter the handler actually parses.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16239
Signed-off-by: Kopylov Pavel <pkopylov at cloudlinux.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
Reviewed-by: Jennifer Sutton <jennifersutton at catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Sep 11 16:10:09 UTC 2026 on atb-devel-224
(cherry picked from commit b54246e258dd3dbd94a112ac460318b27de1d6fd)
- - - - -
c6777ae5 by Björn Jacke at 2026-09-14T20:54:41+00:00
WHATSNEW.txt: fix typo to make codespell and autobuild happy
Signed-off-by: Bjoern Jacke <bjacke at samba.org>
Autobuild-User(v4-24-test): Björn Jacke <bjacke at samba.org>
Autobuild-Date(v4-24-test): Mon Sep 14 20:54:41 UTC 2026 on atb-devel-224
- - - - -
341f09fc by Stefan Metzmacher at 2026-10-01T23:34:14+00:00
s3:winbindd: make all struct winbindd_child their own talloc context
Before we had winbindd_child_msg_filter() crashing in this:
struct winbindd_child *child = talloc_get_type_abort(private_data,
struct winbindd_child);
We could just remove talloc_get_type_abort() there, but
the same problem can come back in other places.
So the domain maintains an array of pointers now.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16081
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
(cherry picked from commit 613563e6d22adb82bdeacf72014478324631fab0)
- - - - -
f203c932 by Anoop C S at 2026-10-01T23:34:14+00:00
smbd: Fix temporary mkdir name allocation check
Check the talloc_asprintf() result stored in tmp_atname->base_name
instead of rechecking the already validated tmp_atname pointer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16240
Signed-off-by: Anoop C S <anoopcs at samba.org>
Reviewed-by: Noel Power <noel.power at suse.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 523327cce7cf8a977b10c5d57a3477aa2ebac3b8)
- - - - -
e4e1f2dd by Anoop C S at 2026-10-01T23:34:14+00:00
s4/torture: Add smb2 long mkdir name test
Add a regression test that creates a directory with a 255-byte
component. Mark it as a known failure until smbd stops embedding
the complete client name in its longer internal temporary name.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16240
Signed-off-by: Anoop C S <anoopcs at samba.org>
Reviewed-by: Noel Power <noel.power at suse.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit b8826db2da7dadf1a56310f523e4cef4374cf98b)
- - - - -
5c529e6e by Anoop C S at 2026-10-01T23:34:14+00:00
smbd: Use bounded temporary names for mkdir
mkdir_internal() appends the complete client name to the temporary
directory prefix. A valid client name near NAME_MAX therefore becomes
too long after Samba adds its internal prefix, and mkdirat() fails
with ENAMETOOLONG.
Use a fixed size GUID suffix while retaining the server ID needed for
stale name detection. This preserves the existing atomic create, setup
and rename behavior without reducing the filename space available to
clients. Also update the parameter documentation and remove the
regression test from knownfail.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16240
Signed-off-by: Anoop C S <anoopcs at samba.org>
Reviewed-by: Noel Power <noel.power at suse.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Anoop C S <anoopcs at samba.org>
Autobuild-Date(master): Sun Sep 13 06:08:46 UTC 2026 on atb-devel-224
(cherry picked from commit 86c7c3ed32b4d38cd3aa75b3c5bb065380c0319f)
- - - - -
583d854f by Anoop C S at 2026-10-01T23:34:14+00:00
s3/g_lock: Create the stack frame before the fast path
The fast path calls talloc_tos() before a stack frame exists when
invoked by callers such as the smbconf Python bindings. Allocate the
frame before this path and route exits through a common label.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16258
Signed-off-by: Anoop C S <anoopcs at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
(cherry picked from commit fdf6726c1c6f7274675f070c0d0761ea5101fd4b)
- - - - -
761ed8a7 by Anoop C S at 2026-10-01T23:34:14+00:00
s3/smbconf: Avoid leaking a stack frame for a NULL share name
Allocate the stack frame after the NULL servicename check so the
early return in smbconf_reg_create_share() does not leak it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16258
Signed-off-by: Anoop C S <anoopcs at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Sep 30 21:26:41 UTC 2026 on atb-devel-224
(cherry picked from commit c670e4fce53c04d3d41a47af403e771f34250fe1)
- - - - -
37b5184c by Martin Schwenke at 2026-10-01T23:34:14+00:00
ctdb-daemon: Modernise a DEBUG
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16254
Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
(cherry picked from commit 792942b7e9cfb51dac3ec1c406f40570098d429c)
- - - - -
ac2e896c by Martin Schwenke at 2026-10-01T23:34:14+00:00
ctdb-server: Apply some README.Coding, improve comments
Some comments in the same function aren't changed now because they
will be changed in a subsequent commit when the behaviour changes..
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16254
Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
(cherry picked from commit 6420aba887c09590bbd46706b0a8ebdd4b848a96)
- - - - -
e9f87255 by Martin Schwenke at 2026-10-01T23:34:14+00:00
ctdb-daemon: Fix conditions for choosing persistent traverse node
The local node doesn't have to be in the VNN map, since it might have
the lmaster capability disabled. It just needs to be active.
Otherwise, still prefer the first node in the VNN map. Be defensive
about selecting it even though the VNN map should never be empty.
Fall back to selecting the first active node (which won't have been
found in the VNN map if it has the lmaster capability disabled).
If there is no active node then fail.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16254
Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
(cherry picked from commit 65d55e410bc217e8ba02c7194a53412366dc8443)
- - - - -
6906c874 by Martin Schwenke at 2026-10-01T23:34:14+00:00
ctdb-daemon: Persistent transactions go to all active nodes
The VNN map only contains active nodes with the lmaster capability.
However, transactions on persistent databases should involve all
active nodes. So, don't use the VNN map, use the nodes list instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16254
Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
(cherry picked from commit a8b99d264b87d96fe4af377ac127e64920d9ad1f)
- - - - -
6550b974 by Martin Schwenke at 2026-10-02T00:37:48+00:00
ctdb-tests: Add a persistent transaction test
Test that a persistent transaction also writes to nodes with the
lmaster capability disabled.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16254
Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
(cherry picked from commit f2fba08c1d7fc616ded2690b10ebefe86a17a5c0)
Autobuild-User(v4-24-test): Björn Jacke <bjacke at samba.org>
Autobuild-Date(v4-24-test): Fri Oct 2 00:37:48 UTC 2026 on atb-devel-224
- - - - -
5143a840 by Shweta Sodani at 2026-10-05T14:50:11+00:00
lib/util: backend file level log is not respected to "logging" option.
With the help of "logging" option, we can set the each logging backend
with different level, this is working fine for all backend logging
except file level logging. This change is respecting the file level
logging as well.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15857
Signed-off-by: Shweta Sodani <ssodani at redhat.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Oct 1 22:32:48 UTC 2026 on atb-devel-224
(cherry picked from commit 019e7e304e4d9cb053341ebec9e801b852164481)
- - - - -
132c18f8 by Volker Lendecke at 2026-10-05T14:50:11+00:00
selftest: Add regression test for rename ReplaceIfExists case-only collision
Add samba.tests.libsmb-basic.LibsmbTestCase.test_rename_replace_case,
which renames a temporary file over an existing target differing only
in case with ReplaceIfExists set. The existing target must be replaced,
not left in place alongside a second, duplicate directory entry.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16261
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Anoop C S <anoopcs at samba.org>
(cherry picked from commit a798b16fc76b968d8af64409e6365791bbd62419)
- - - - -
31e9fe26 by Volker Lendecke at 2026-10-05T15:53:29+00:00
smbd: Fix rename with ReplaceIfExists to a target differing only in case
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16261
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Anoop C S <anoopcs at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Sep 29 19:34:05 UTC 2026 on atb-devel-224
(cherry picked from commit 15f64c46c935b428d1827a170ee4082694464c19)
Autobuild-User(v4-24-test): Björn Jacke <bjacke at samba.org>
Autobuild-Date(v4-24-test): Mon Oct 5 15:53:29 UTC 2026 on atb-devel-224
- - - - -
cace7d01 by Martin Schwenke at 2026-10-10T20:50:02+00:00
ctdb-recoverd: Avoid recovery race on lost cluster lock
The following was seen while running
ctdb/tests/INTEGRATION/simple/cluster.015.reclock_remove_lock.sh:
726102 node.0 ctdbd[2655369]: ctdb_mutex_fcntl_helper: lock lost - lock file "tests/var/INTEGRATION/simple/shared/.ctdb/cluster.lock" open failed (ret=2)
726937 node.0 ctdb-recoverd[2655437]: Cluster lock helper terminated
726971 node.0 ctdb-recoverd[2655437]: Start election
727053 node.0 ctdbd[2655369]: Recovery mode set to ACTIVE
727071 node.1 ctdbd[2655392]: Recovery mode set to ACTIVE
727071 node.2 ctdbd[2655407]: Recovery mode set to ACTIVE
727161 node.0 ctdb-recoverd[2655437]: Attempting to take cluster lock (! /m/martins/aMASTER/b1443461/ctdb/ctdb/bin/ctdb_mutex_fcntl_helper tests/var/INTEGRATION/simple/shared/.ctdb/cluster.lock 5)
727198 node.1 ctdb-recoverd[2655480]: Attempting to take cluster lock (! /m/martins/aMASTER/b1443461/ctdb/ctdb/bin/ctdb_mutex_fcntl_helper tests/var/INTEGRATION/simple/shared/.ctdb/cluster.lock 5)
727212 node.2 ctdb-recoverd[2655503]: Attempting to take cluster lock (! /m/martins/aMASTER/b1443461/ctdb/ctdb/bin/ctdb_mutex_fcntl_helper tests/var/INTEGRATION/simple/shared/.ctdb/cluster.lock 5)
727885 node.0 ctdb-recoverd[2655437]: Received leader broadcast, leader=0
731562 node.0 ctdb-recoverd[2655437]: Unable to take cluster lock - contention
731579 node.2 ctdb-recoverd[2655503]: Unable to take cluster lock - contention
731587 node.1 ctdb-recoverd[2655480]: Cluster lock taken successfully
731602 node.1 ctdb-recoverd[2655480]: Took cluster lock, leader=1
731976 node.0 ctdb-recoverd[2655437]: Node:0 was in recovery mode. Start recovery process
732006 node.0 ctdb-recoverd[2655437]: Node:1 was in recovery mode. Start recovery process
732022 node.0 ctdb-recoverd[2655437]: Node:2 was in recovery mode. Start recovery process
732029 node.0 ctdb-recoverd[2655437]: do_recovery: Starting do_recovery
732035 node.1 ctdb-recoverd[2655480]: Node:1 was in recovery mode. Start recovery process
732050 node.1 ctdb-recoverd[2655480]: Node:0 was in recovery mode. Start recovery process
732059 node.1 ctdb-recoverd[2655480]: Node:2 was in recovery mode. Start recovery process
732062 node.0 ctdb-recoverd[2655437]: Cluster lock not held - abort recovery, ban node
732063 node.1 ctdb-recoverd[2655480]: do_recovery: Starting do_recovery
732067 node.0 ctdb-recoverd[2655437]: Banning node 0 for 300 seconds
732082 node.0 ctdbd[2655369]: SET BAN STATE
732090 node.0 ctdbd[2655369]: Banning this node for 300 seconds
732094 node.0 ctdbd[2655369]: Making node INACTIVE
732096 node.1 ctdb-recoverd[2655480]: do_recovery: Recovery initiated due to problem with node 0
Note that the date/time has been trimmed to just show microseconds for
readability.
The problem here is that the node that lost the cluster lock still
has itself recorded as leader. By the time it attempts to run
recovery, it hasn't received a leader broadcast from the new leader
so it passes all the checks allowing it to run recovery, except for
the cluster lock one.
Clearing the leader on this node will avoid the problem because
do_recovery() will notice it is no longer the leader and will abort
recovery.
Improve the associated message in do_recovery() to avoid printing the
confusing value of CTDB_UNKNOWN_PNN when this occurs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16273
Signed-off-by: Martin Schwenke <mschwenke at ddn.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Anoop C S <anoopcs at samba.org>
Autobuild-User(master): Anoop C S <anoopcs at samba.org>
Autobuild-Date(master): Fri Oct 9 18:47:25 UTC 2026 on atb-devel-224
(cherry picked from commit a01ade983b71640332798a97e7d6bcaa454b78ca)
Autobuild-User(v4-24-test): Björn Jacke <bjacke at samba.org>
Autobuild-Date(v4-24-test): Sat Oct 10 20:50:02 UTC 2026 on atb-devel-224
- - - - -
a0910e9c by Stefan Metzmacher at 2026-10-12T16:42:16+00:00
lib/util: make generate_unique_u64() more robust
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16200
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
(cherry picked from commit 89968416949541e547bc1eb7605b8f3e5f893e0b)
- - - - -
af2c38e0 by Volker Lendecke at 2026-10-12T16:42:16+00:00
tests: The fix for Bug 16200 causes a locking corruption bug
smbd caches share_mode_data and reuses it as long as the
unique_content_epoch of the locking.tdb record is unchanged.
Right now a fresh smbd hands out the same epochs as the smbd that
created a record before. Make c2's smbd cache the share_mode_data of a
record created by c1, remove the record and let a third connection
recreate it with a different share mode. c2 then uses its cached
share_mode_data and misses the sharing violation.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16200
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit f92b40e9ce29c70b970d932b962d25ccfe2d2cc3)
- - - - -
4086da33 by Volker Lendecke at 2026-10-12T17:45:16+00:00
lib: seed generate_unique_u64() per process again
Since commit 89968416949 ("lib/util: make generate_unique_u64() more
robust") the first call in a process sets next_value to veto_value and
increments it before the veto check. So the random nonce is never
generated, and every process continues counting from the value it was
passed. Processes that start from the same value, for example the
unique_content_epoch of the same locking.tdb record, hand out the same
"unique" values. New g_lock records get unique_lock_epoch 1 and
unique_data_epoch 2 in every fresh process.
share_mode_memcache_fetch() relies on unique_content_epoch being unique
across processes to detect stale cached share_mode_data, g_lock relies
on unique_data_epoch to detect data changes for watchers. With
colliding epochs an smbd can use outdated share_mode_data or miss a
change of g_lock data.
Start every process at a random value as documented in samba_util.h.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=16200
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Oct 9 09:42:26 UTC 2026 on atb-devel-224
(cherry picked from commit 67eeb79811e57038a38d7272ee98064938b27b06)
Autobuild-User(v4-24-test): Björn Jacke <bjacke at samba.org>
Autobuild-Date(v4-24-test): Mon Oct 12 17:45:16 UTC 2026 on atb-devel-224
- - - - -
511acb9a by Björn Jacke at 2026-10-12T20:32:25+02:00
WHATSNEW: Add release notes for Samba 4.24.8.
Signed-off-by: Bjoern Jacke <bjacke at samba.org>
- - - - -
24570872 by Björn Jacke at 2026-10-12T20:33:30+02:00
VERSION: Disable GIT_SNAPSHOT for the 4.24.8 release.
Signed-off-by: Bjoern Jacke <bjacke at samba.org>
- - - - -
34922153 by Michael Tokarev at 2026-10-14T10:02:14+03:00
New upstream version 4.24.8+dfsg
- - - - -
d83f8d1f by Michael Tokarev at 2026-10-14T10:02:31+03:00
Update upstream source from tag 'upstream/4.24.8+dfsg'
Update to upstream version '4.24.8+dfsg'
with Debian dir 5e231940c6623bc3f5f0563459ff2c6e1dbaf25d
- - - - -
d4435d2c by Michael Tokarev at 2026-10-14T10:06:24+03:00
update changelog; upload version 4.24.8+dfsg-1 to unstable
- - - - -
33 changed files:
- VERSION
- WHATSNEW.txt
- ctdb/server/ctdb_persistent.c
- ctdb/server/ctdb_recoverd.c
- ctdb/server/ctdb_traverse.c
- + ctdb/tests/INTEGRATION/database/transaction.005.ptrans_lmaster.sh
- debian/changelog
- docs-xml/smbdotconf/vfs/vfsmkdirusetmpname.xml
- lib/param/loadparm.c
- lib/util/debug.c
- lib/util/genrand_util.c
- libcli/smb/smbXcli_base.c
- libcli/smb/smbXcli_base.h
- python/samba/tests/libsmb-basic.py
- python/samba/tests/param.py
- source3/lib/g_lock.c
- source3/lib/smbconf/smbconf_reg.c
- source3/smbd/open.c
- source3/smbd/smb2_reply.c
- source3/smbd/smb2_server.c
- source3/torture/test_smb2.c
- source3/winbindd/winbindd.h
- source3/winbindd/winbindd_domain.c
- source3/winbindd/winbindd_dual.c
- source3/winbindd/winbindd_idmap.c
- source3/winbindd/winbindd_locator.c
- source3/winbindd/winbindd_ndr.c
- source3/winbindd/winbindd_proto.h
- source3/winbindd/winbindd_util.c
- source4/libcli/smb2/session.c
- source4/torture/smb2/mkdir.c
- source4/torture/smb2/session.c
- source4/torture/smb2/smb2.c
The diff was not included because it is too large.
View it on GitLab: https://salsa.debian.org/samba-team/samba/-/compare/cdc916f0902ef3fea80cdf8bc5fb8aa0eaef2f65...d4435d2c1fbecfaf725ce37eea4071f463116cc4
--
View it on GitLab: https://salsa.debian.org/samba-team/samba/-/compare/cdc916f0902ef3fea80cdf8bc5fb8aa0eaef2f65...d4435d2c1fbecfaf725ce37eea4071f463116cc4
You're receiving this email because of your account on salsa.debian.org. Manage all notifications: https://salsa.debian.org/-/profile/notifications | Help: https://salsa.debian.org/help
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-samba-maint/attachments/20261014/5123773e/attachment-0001.htm>
More information about the Pkg-samba-maint
mailing list