Bug#565788: Upgrading SDL breaks Wesnoth

[Barry deFreese]

On 4/8/2010 2:15 PM, Mark de Wever wrote:
> On Tue, Apr 06, 2010 at 09:19:11PM +0100, Adam D. Barratt wrote:
>> On Mon, 2010-01-18 at 21:38 +0100, Mark de Wever wrote:
>>> Upgrading libsdl from 1.2.13-5 to 1.2.14-3 breaks Wesnoth. I tested with
>>> both Wesnoth 1.6.5-1 and a recent upstream Wesnoth trunk revision.
>>> Somebody did some more testing [1] and the problem seems to depend on
>>> the WM (I use fvwm). We also have a conversation with Sam Lantinga on
>>> our mailinglist [2][3][4].
>>>
>>> The problem is that after the upgrade the buttons in the user interface
>>> no longer work. Clicking with the mouse on a button in the main menu
>>> does nothing at all, rendering Wesnoth completely unusable.
>>
>> I've replicated this issue using fvwm on amd64 and have found the cause.
>>
>> After importing the svn repository in to git and "git bisect"ing, the
>> problem appears to be due to the first hunk of upstream r4872 (fixing
>> their #716); the attached diff makes the mouse work as expected in my
>> testing.
> 
> Thanks for your effort in investigating and fixing this bug. I build a
> package with your patch on my system (i386 architecture). After
> installing the package the mouse buttons in Wesnoth work again as
> expected, so your patch fixes the issue for me.
> 

My apologies that I haven't been keeping up with SDL lately, real life is killing me.  I will see if
I can get this tested also, and then updated.

Thanks!

Barry deFreese