Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

[Manuel A. Fernandez Montecelo]

2013/8/9 Dominique Dumont <dod at debian.org>:
> On Thursday 08 August 2013 19:13:24 Manuel A. Fernandez Montecelo wrote:
>> I meant to modify the first patch bug-715461-soundfont_paths.patch so
>> when that variable "soundfont_paths" is assigned, it's done with
>> SDL_strdup() (it's done in several places in the code --that's where I
>> got the idea from--, so "it fits"), and remove the second patch
>> altogether, bug-718129-rm-bad-free.patch.
>
> Understood.
>
>> The variable can be set by users of the library to use dynamic memory
>> [1], so removing that SDL_free() is theoretically incorrect -- if it
>> gets assigned other content in runtime, it would not free it where the
>> SDL_free() is removed (which is the end of the program, so actually it
>> shoudn't be that important, bug e.g. valgrind would report it as a
>> leak).
>
> I think "soundfont_paths" initialisation should be done in Mix_Init().
>
> Otherwise a sequence of Mix_Init, Mix_Quit, Mix_Init and Mix_Quit will lead to
> a segfault. This sequence may not make sense from a user's point of view, but
> it may happen in test suites like SDL-perl's test suite.
>
>> And Dominique, sorry that I didn't catch this when you asked me, I was
>> busy at work and couldn't pay full attention to the issue.
>
> Don't worry about it. Been there, done that ;-)
>
> All the best

So... does this look OK to both of you (I didn't actually upload,
waiting for your confirmation)?

The commit diff is needlessly long due to issues with dos/unix line
ending, but I guess that you get the idea comparing previous and
current versions of the patch.

commit diff:
http://anonscm.debian.org/gitweb/?p=pkg-sdl/packages/sdl-mixer1.2.git;a=commitdiff;h=ef1b4991e313ea2ef840af3291e6e8b77f9e60be

current version of the patch:
http://anonscm.debian.org/gitweb/?p=pkg-sdl/packages/sdl-mixer1.2.git;a=blob;f=debian/patches/bug-715461-soundfont_paths.patch;h=bf2fe632a3ea38de28a079138e7ab3627d7fdd57;hb=ef1b4991e313ea2ef840af3291e6e8b77f9e60be

previous version:
http://anonscm.debian.org/gitweb/?p=pkg-sdl/packages/sdl-mixer1.2.git;a=blob;f=debian/patches/bug-715461-soundfont_paths.patch;h=71faacc115df02713bae2e6211368bc24d2577cc;hb=06b5b0ea8a1417ca356e5055ce5855df8dbfcbd6


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>