Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

[Manuel A. Fernandez Montecelo]

2013/8/26 Fabian Greffrath <fabian at greffrath.com>:
> Am Dienstag, den 20.08.2013, 09:58 +0200 schrieb Fabian Greffrath:
>> Yes, it does. However, I would have added a check if the pointer is
>> already set prior to resetting it, e.g.
>>
>> if (!soundfont_paths)
>> soundfont_paths = SDL_strdup(...);
>>
>> But this is really just nit-picking.
>
> Wait, does SDL_strdup() allocate new memory and isn't the current
> solution leaking memory when Mix_Init() is repeatedly called?

Yes, I don't think that it will be a real issue except if programs do
real weird things (even the tests are not likely to exhaust any memory
doing this).  But it can be fixed properly anyway, just didn't find
the time to do that.

What it concerns me more is to have to carry the patch around,
modifying it for SDL2, etc.

Do you think that it could be modified to be less system dependent, in
a way that it would be accepted upstream?  Perhaps passing it at
compilation time, instead of having to patch or export at runtime?
Would they be interested in something like this at all?


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>