Bug#726912: libsdl-mixer1.2: Music with TiMidity backend plays too fast

[Manuel A. Fernandez Montecelo]

2013/10/20 Sylvain <beuc at debian.org>:
> Hi,
>
> On Sun, Oct 20, 2013 at 06:10:24PM +0100, Manuel A. Fernandez Montecelo wrote:
>> It would be great if you could recompile the deb package with that
>> patch disabled and test it if plays the file, and other files of
>> freedink, and see if it doesn't segfault (some modification of the
>> current patch would be needed, I guess, that's why the patch was
>> devised in the first place).
>
> As I'm such a great guy I ran a few tests ;)

Thanks :-)

> SDL_FORCE_SOUNDFONTS=1 ./playmus /usr/share/games/dink/dink/Sound/104.mid
> SDL_FORCE_SOUNDFONTS=1 ./playmus /tmp/midibug/sound/10.mid
>
>
> Results:
>
> upstream + bare ./configure
> - 104.mid: OK
> - minibug: OK
>
> upstream + bare ./configure + bug-694260-freedink_stack_corruption.patch:
> - 104.mid: faster tempo
> - minibug: slower tempo
>
> current debian:
> - 104.mid: faster tempo
> - minibug: still crashes! #694260 ain't fixed!
>
> current debian - all patches:
> - 104.mid: OK
> - minibug: still crashes!
>
> current debian - all patches - -fstatck-protector:
> - 104.mid: OK
> - minibug: OK
>

> Conclusions:
> - bug-694260-freedink_stack_corruption.patch doesn't fix the crash
> - bug-694260-freedink_stack_corruption.patch introduces a new bug
> Sorry pals :)

I'm having a bit of a problem with the terminology so I cannot make
sense of the cases that you explain:

- Does "current debian - all patches" mean "minus all patches, that
is, no patches applied", or "current debian, with all patches
applied"?

- "current debian" means as the binary package, "all patches
included", or "current version of the code as shipped in .orig.tar,
but no patches"?

- and more importantly, upstream is the same version as Debian's
.orig.tar, that is 1.2.12, or the HEAD, or something else?


Upstream created the patch later than 1.2.12 and I think that it's
carried in 2.0.0, so it's important to ask the patch to be reverted if
it's wrong.

According to your cases above, if "upstream" works without the patch
but not with the patch applied, it means that you are using either
1.2.12, or later but they already reverted the patch.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>