Bug#735289: libsdl2-gfx -- basic antialiased drawing for SDL2
Manuel A. Fernandez Montecelo
manuel.montezelo at gmail.com
Sat Jan 18 19:27:14 UTC 2014
Hi again Gianfranco,
You already changed the source name that I just mentioned in other
email while I was writing this, there are at least the issues from
this past email quoted below.
- sorry to be picky about this again, but to follow the pattern of the
packages, the name should be "libsdl2-gfx", with the "-"
- there's still no "-dbg" package, should be easy to do by copying
what other SDL modules do
- copyright is still the same as before. It's almost compliant with
the format (so hopefully it will be a small job to fix it), but not
completely, and since there's a strict format it will be better to be
100% conformant.
Field names, contents and so on documented here:
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
- I also discovered that the watch file looks for the version of gfx
for SDL1, not SDL2
I now built the package successfully and lintian seems happy and so
on, so when this is fixed we are good to go.
Cheers.
--
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>
2014/1/15 Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>:
> Review of the package...
>
> 2014/1/14 Gianfranco Costamagna <costamagnagianfranco at yahoo.it>:
>> Package: wnpp
>> Severity: wishlist
>> Owner: Debian SDL packages maintainers <pkg-sdl-maintainers at lists.alioth.debian.org>
>>
>> * Package name : libsdl2-mixer
>
> Not important, but you left "mixer" in there :-)
>
>
> * debian/control
>
> --- you left "sdl2gfx" as package name (same for debian/changelog)
>
> --- I don't know if you should add yourself to uploaders, even if at
> the moment you cannot actually upload. I am not 100% sure about the
> correct thing to do in this case (please see the documentation and do
> whatever it recommeds that is right).
>
> --- it's better if you have a -dbg package, we provide it with the
> rest of them, because it's easier to tell people to post useful
> backtraces when they report crashes
>
>
> * debian/copyright
>
> --- the format of the file should follow the other ones, documentation
> of valid Fields in the URL of the first lines of the other ones (it's
> almost there)
>
>
> * debian/source/lintian-overrides
>
> --- this should be fixed instead of adding the override, and the
> override file removed (you already build-depend on debhelper >= 9
> anyway)
>
>
> I didn't try to build but looks quite good.
>
>
> Cheers.
> --
> Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>
More information about the Pkg-sdl-maintainers
mailing list