Bug#788061: Bug#788057: game-data-packager: please add support for Blake Stone: Aliens of Gold and Planet Strike

Manuel A. Fernandez Montecelo manuel.montezelo at gmail.com
Tue Jun 30 18:40:45 UTC 2015


2015-06-30 13:00 GMT+01:00 Fabian Greffrath <fabian at debian.org>:
> @pkg-sdl: Please have a look at the post/patches linked to in the
> second paragraph. :)

I have had a look at some of the patches, not in much detail though
(I'm in a bit of a rush in the last few weeks).

Perhaps some of them, at least the most simple and obvious, should be
(if not done already) reported in the bug tracker, attaching the
particular patch fixing the issue.  I saw upstream happily accepting
patches in the past (although they are a bit slow to react sometimes).

So Braden already did the right think in trying to upstream his
changes, but breaking them down to small pieces for individual
consideration will help a lot in the process, I think.

In principle, I think that the changes as a whole are too big and
intrusive to try to add them to Debian.  I am sure that some/most are
good fixes, but we have had continous problems with adding some patch
that people request to fix a problem in their project, and then
breaking another application for not obvious reasons, sometimes those
other applications even rely on the wrong/old behaviour.  So adding
patches without support from upstream is a bit of a mine-field.

>> Well, I don't know the whole story, but if there really is something
>> broken in SDL_mixer, I'd rather have it fixed upstream for all games.
> His patches were posted on the upstream dev list, but got no response
> so far:
> http://lists.libsdl.org/pipermail/sdl-libsdl.org/2015-June/098221.html
> I guess upstream considers SDL*-1.2 dead and does not accept any
> patches anymore. :( But maybe our SDL packagers at Debian could use
> some of them. I am thus including them in CC. :)

Maybe it's obvious from previous context, but I didn't see how this
applied to SDL-1.2 and not v2?  I think that specially the mixer
module is quite independent from other changes of the v2 library, so I
think that many might apply to v2 as well.

Speaking of which, if an active software has not considered starting
to use v2 already, at least they should make a plan.  We don't plan to
retire 1.2 immediately, but it's obvious that upstream does not do any
releases of that branch, nor probably even accepts patches, so it
starts to be urgent to move on to the supported versions.

Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>

More information about the Pkg-sdl-maintainers mailing list