Bug#822210: sdl2-config.cmake: extra leading / trailing whitespace

[Gianfranco Costamagna]

Hi Manuel and libsdl2 developers!


How do you feel about the patch below?
I think we should apply it, to avoid cmake breakages in linux systems.

thanks for considering it,

--- a/configure.in
+++ b/configure.in
@@ -97,7 +97,7 @@
 
 if test x$have_no_cygwin = xyes; then
 BASE_CFLAGS="-mno-cygwin"
-            BASE_LDFLAGS="-mno-cygwin"
+            BASE_LDFLAGS=" -mno-cygwin"
 fi
 BASE_CFLAGS="$BASE_CFLAGS -I/usr/include/mingw"
 ;;
@@ -123,7 +123,7 @@
 #    fi
 #done
 SDL_CFLAGS="$BASE_CFLAGS"
-SDL_LIBS="-lSDL2 $BASE_LDFLAGS"
+SDL_LIBS="-lSDL2$BASE_LDFLAGS"
 CPPFLAGS="$CPPFLAGS $EXTRA_CFLAGS"
 CFLAGS="$CFLAGS $EXTRA_CFLAGS"
 LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS"

(probably also BASE_CFLAGS needs some similar patching)

cheers,


Gianfranco


Il Domenica 24 Aprile 2016 19:22, Jason Pleau <jason at jpleau.ca> ha scritto:
Hi Gianfranco,

On Fri, 22 Apr 2016 14:23:53 +0200 Gianfranco Costamagna
<locutusofborg at debian.org> wrote:
> Hi,
> > set(SDL2_LIBRARIES "-L${SDL2_LIBDIR}  -lSDL2 ")
> 
> I know where that space comes from:
> 
> quoting configure.in
> 
> SDL_LIBS="-lSDL2 $BASE_LDFLAGS"
> 
> 
> changing to 
> SDL_LIBS="-lSDL2$BASE_LDFLAGS"
> 
> fixes the issue, because in our case BASE_LDFLAGS is undefined.
> 
> I'm not sure why the cmake build is not even creating it, and I'm not sure how
> to best fix the issue.
> 
> I think a patch would be welcome, so the maintainers can apply it if needed :)

I attached a patch, would something like this be an acceptable solution
? If yes I think we should forward upstream

> 
> thanks for the bug report,
> 
> Gianfranco
> 

-- 
Jason Pleau