Bug#814276: Non-Free file: src/stdlib/SDL_qsort.c

[Manuel A. Fernandez Montecelo]

2016-02-15 8:29 GMT+00:00 Ryan C. Gordon <icculus at icculus.org>:
>
> I've changed the implementation. It's now public domain code from PDCLib.
>
>     https://hg.libsdl.org/SDL/rev/19998f9082dc
>
> We have no intention of shipping another release of SDL 1.2, but on 1.2,
> SDL_qsort is #defined to qsort in the headers if HAVE_QSORT is set by the
> configure script...that is to say, if Debian wants to replace SDL_qsort.c
> with an empty file for its SDL 1.2 package, it will likely build the exact
> same binary.
>
> Let me know if you have any other concerns.

Thanks for the quick fix and the explanations.

I was looking into how to fix this and have another question, brief
explanation follows.

Since in Debian and derivatives we distribute the source as well, we
have to repack the .orig.tar as if it was a new upstream release,
removing the (from Debian's PoV) non-free file, so it gives some extra
work compared to most patches/fixes.

So since we have to do that, I was considering to pack the hg-head to
have a proper "new upstream release", or at least some important fixes
that might have accumulated since 2.0.4.  But when I looked I realised
that there are dozens of commits already since 2.0.4.

At the risk of sounding like a broken record... would you consider to
create a new upstream release in the next couple of weeks or so?

It's close to 2 months since 2.0.4, and if you keep adding things at
this rate and don't make a new release soon, maybe the same situation
happens as with the big gap between 2.0.3 and .4.

If you don't plan to do a new release so soon I/we will fix it at our
end with the current fix, but nevertheless I think that it would be
good to have a new upstream release soonish.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>