Bug#822210: sdl2-config.cmake: extra leading / trailing whitespace

Manuel A. Fernandez Montecelo manuel.montezelo at gmail.com
Sun May 1 14:42:26 UTC 2016


2016-04-30 2:35 GMT+01:00 Jason Pleau <jason at jpleau.ca>:
> On 04/29/2016 06:44 AM, Manuel A. Fernandez Montecelo wrote:
>> Jason, if you want to test it to see if it works fine, then I can
>> submit both to upstream's bug report for them to decide.
>
> It looks like ${prefix} is not set when defining ${stripped_prefix}. So
> for example SDL2_INCLUDE_DIRS is set to /include/SDL2.

Thanks for testing!


> I got it to work with the following:
>
> # sdl2 cmake project-config input for ./configure scripts
>
> string(STRIP "@prefix@" prefix)
> string(STRIP "@exec_prefix@" stripped_exec_prefix)
> string(STRIP "@libdir@" stripped_libdir)
> string(STRIP "@includedir@" stripped_includedir)
> string(STRIP "-L${SDL2_LIBDIR} @SDL_RLD_FLAGS@ @SDL_LIBS@"
> stripped_SDL2_LIBRARIES)
>
> set(exec_prefix "${stripped_exec_prefix}")
> set(libdir "${stripped_libdir}")
> set(SDL2_PREFIX "${stripped_prefix}")
> set(SDL2_EXEC_PREFIX "${stripped_prefix}")
> set(SDL2_LIBDIR "${stripped_libdir}")
> set(SDL2_INCLUDE_DIRS "${stripped_includedir}/SDL2")
> set(SDL2_LIBRARIES "${stripped_SDL2_LIBRARIES}")

So you only changed the first line, compared to mine?

If it needs this change, I think that my solution is not very robust
and that the assumptions made don't work and can fail in other cases.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo at gmail.com>



More information about the Pkg-sdl-maintainers mailing list