Bug#909778: libsdl2-dev: SDL_config.h no longer in cflags provided by pkg-config/sdl2-config

[Adrian Bunk]

On Fri, Sep 28, 2018 at 12:47:28PM +0000, Hugh McMaster wrote:
> On Friday, 28 September 2018 5:09 PM, Simon McVittie wrote:
> > This is a regression caused by fixing #909740. Hugh McMaster correctly
> > pointed out that /usr/include/<triplet> is one of the default search
> > paths for headers. However, SDL_config.h is designed to be included as
> > <sdl_config.h> after -I/usr/include/SDL2, not as <sdl2 sdl_config.h="">,
> > according to the design documented in <https: ometer.com="" parallel.html="">
> > and popularized by packages like GLib and GTK+; so moving it to
> > /usr/include/<triplet>/SDL2 does not make it includable. How was the
> > patch in #909740 tested?
> 
> > If sdl2-config didn't exist, then this would be easy to fix by adding
> > -I/usr/include/<triplet>/SDL2 to the pkg-config file (similar to what
> > happens in GLib); but doing the same thing in sdl2-config would give it
> > per-architecture variation and make it non-co-installable, so that isn't
> > an option here.
> 
> The best solution is to drop sdl2-config... but, sadly, that is in an ideal
> world.

sdl2-config is not to blame.

> Patching pkg-config is definitely the way to go.
>...

No, it is definitely not the way to go.

It is wrong that you are doing this fragile manual moving at all.

The following fixes it properly:
- revert the override_dh_install change, and
- add --includedir=\$${prefix}/include/$(DEB_HOST_MULTIARCH) to confflags

Things just work when you are using the facilities provided by the build 
system, instead of adding hack after hack when working against the build
system.

And doing it the right way automatically does the right thing for both 
pkg-config and sdl2-config.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed