Bug#909778: libsdl2-dev: SDL_config.h no longer in cflags provided by pkg-config/sdl2-config

[Hugh McMaster]

> On 30 Sep 2018, at 12:01 am, Adrian Bunk <bunk at debian.org> wrote:
> 
>> On Sat, Sep 29, 2018 at 01:39:05PM +0000, Hugh McMaster wrote:
>>> On Saturday, 29 September 2018 5:06 AM, Adrian Bunk wrote:
>>> The following fixes it properly:
>>> - revert the override_dh_install change, and
>>> - add --includedir=\$${prefix}/include/$(DEB_HOST_MULTIARCH) to confflags
>> 
>> This won't do what you think it will. Unfortunately:
>> 
>> 1. All headers end up being installed into /usr/include/<triplet>/SDL2.
>>   -- Not what we want.
> 
> This is not a problem.

True, but not ideal.

>> 2. /usr/include/<triplet>/SDL2 is hard-coded into sdl2-config, causing a file
>>    conflict for multi-arch installations.
>> ...
> 
> This is actually a problem.
> 
> The minimal fix for that problem would be to add a dependency on 
> pkg-config to libsdl2-dev, and then do
>     --cflags)
> -      echo -I at includedir@/SDL2 @SDL_CFLAGS@
> +      pkg-config --cflags sdl2
>       ;;

I’m not able to check right now, but I believe this will cause problems when libsdl2-dev is installed for a foreign architecture, because sdl2-config will call pkg-config for the native architecture instead. It would need to be qualified with the GNU triplet.