Bug#950627: Regression: Unable to config with CMake

[Simon McVittie]

Version: 2.0.10+dfsg1-3

On Tue, 04 Feb 2020 at 19:41:11 +0900, Kyuma Ohta wrote:
>  From this version, building any softwares with CMake,
>  not configurable.
>  This is *REGRESSION* of fix of BUG #946496.

This appears to be the same bug as #909740, #951087, etc. and should be
fixed in version 2.0.10+dfsg1-3, which is now available in bullseye and sid.

However, bundling a FindSDL2.cmake "find-module package" with each game
is no longer recommended:

On Tue, 11 Feb 2020 at 01:04:32 +0000, Brian Clinkenbeard wrote:
> Since SDL2 now comes bundled with sdl2-config.cmake, it seems that using 
> an external FindSDL2.cmake is no longer necessary in SDL2 projects using 
> CMake. [...] this seems to be an issue 
> with projects using a legacy way including SDL2 with CMake and not with 
> the package.

Yes. The recommended way to find SDL2 from a CMake project is to rely on
SDL >= 2.0.4 being a "config-file package", like this commit in OpenJK:
https://github.com/JACoders/OpenJK/commit/52030235f052772008d99e6ccb16de48e7ddb688

That change works around the regression in the libsdl2_2.0.10+dfsg1-2
Debian package, but is also a better way to find SDL2 in general.

>  Please [...] apply fixes to CMake package, FindSDL.cmake.

That solution was not possible, because FindSDL2.cmake is bundled with
each game that uses it, rather than being provided by some central
location like SDL or CMake - so bugs in it cannot be fixed, except by
changing every game.

sdl2-config.cmake is the better answer to this because it *is* provided
by SDL.

    smcv