Bug#959987: libsdl-sge: Please make autopkgtests cross-test-friendly

[Steve Langasek]

Package: libsdl-sge
Version: 030809dfsg-9
Severity: minor
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu groovy ubuntu-patch

Hi Manuel,

In Ubuntu, we have moved the i386 architecture to a compatibility-only layer
on amd64, and therefore we are also moving our autopkgtest infrastructure to
test i386 binaries in a cross-environment.

This requires changes to some tests so that they are cross-aware and can do
the right thing.

The libsdl-sge tests currently fail in this environment, because they
include build tests that do not invoke the toolchain in a cross-aware
manner.  I've verified that the attached patch lets the tests successfully
build i386 tests on an amd64 host.

Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment.  Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option.  So this change should be safe to land in your package despite this
not being upstream in autopkgtest.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru libsdl-sge-030809dfsg/debian/tests/compile-libsdl-sge-test0 libsdl-sge-030809dfsg/debian/tests/compile-libsdl-sge-test0
--- libsdl-sge-030809dfsg/debian/tests/compile-libsdl-sge-test0	2015-08-24 08:27:23.000000000 -0700
+++ libsdl-sge-030809dfsg/debian/tests/compile-libsdl-sge-test0	2020-05-07 13:59:46.000000000 -0700
@@ -8,6 +8,12 @@
 
 set -e
 
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+  CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+  CROSS_COMPILE=
+fi
+
 WORKDIR=$(mktemp -d)
 trap "rm -rf $WORKDIR" 0 INT QUIT ABRT PIPE TERM
 cd $WORKDIR
@@ -17,7 +23,7 @@
 # compile
 cp -v $EXAMPLESDIR/* .
 make clean
-make
+make CC=${CROSS_COMPILE}gcc CXX=${CROSS_COMPILE}g++
 echo "build: OK"
 
 # check/execute