Bug#1100236: libsdl2: FTBFS: src/audio/pipewire/SDL_pipewire.c:593:37: error: passing argument 1 of 'pw_node_enum_params' from incompatible pointer type

[Santiago Vila]

Package: src:libsdl2
Version: 2.32.2+dfsg-1
Severity: serious
Tags: ftbfs trixie sid

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

--------------------------------------------------------------------------------
[...]
/bin/bash ./libtool --tag=CC --mode=compile gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -DUSING_GENERATED_CONFIG_H -Iinclude -I/<<PKGBUILDDIR>>/include -idirafter /<<PKGBUILDDIR>>/src/video/khronos  -DSDL_BUILD_MAJOR_VERSION=2 -DSDL_BUILD_MINOR_VERSION=32 -DSDL_BUILD_MICRO_VERSION=2 -mmmx -msse -msse2 -msse3 -Wall -Wno-unused-local-typedefs -fno-strict-aliasing -fvisibility=hidden -Wdeclaration-after-statement -Werror=declaration-after-statement  -I/usr/include/pipewire-0.3 -I/usr/include/spa-0.2 -D_REENTRANT  -D_REENTRANT    -I/usr/include/libdrm    -Igen -I/usr/include/libdecor-0  -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include  -I/usr/include/ibus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libmount -I/usr/include/blkid -pthread  -D_REENTRANT -DHAVE_LINUX_VERSION_H  -c /<<PKGBUILDDIR>>/src/audio/pipewire/SDL_pipewire.c -o build/SDL_pipewire.lo
libtool: compile:  gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -DUSING_GENERATED_CONFIG_H -Iinclude -I/<<PKGBUILDDIR>>/include -idirafter /<<PKGBUILDDIR>>/src/video/khronos -DSDL_BUILD_MAJOR_VERSION=2 -DSDL_BUILD_MINOR_VERSION=32 -DSDL_BUILD_MICRO_VERSION=2 -mmmx -msse -msse2 -msse3 -Wall -Wno-unused-local-typedefs -fno-strict-aliasing -fvisibility=hidden -Wdeclaration-after-statement -Werror=declaration-after-statement -I/usr/include/pipewire-0.3 -I/usr/include/spa-0.2 -D_REENTRANT -D_REENTRANT -I/usr/include/libdrm -Igen -I/usr/include/libdecor-0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/ibus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/libmount -I/usr/include/blkid -pthread -D_REENTRANT -DHAVE_LINUX_VERSION_H -c /<<PKGBUILDDIR>>/src/audio/pipewire/SDL_pipewire.c  -fPIC -DPIC -o build/.libs/SDL_pipewire.o
/<<PKGBUILDDIR>>/src/audio/pipewire/SDL_pipewire.c: In function 'node_event_info':
/<<PKGBUILDDIR>>/src/audio/pipewire/SDL_pipewire.c:593:37: error: passing argument 1 of 'pw_node_enum_params' from incompatible pointer type [-Wincompatible-pointer-types]
  593 |             pw_node_enum_params(node->proxy, 0, info->params[i].id, 0, 0, NULL);
      |                                 ~~~~^~~~~~~
      |                                     |
      |                                     struct pw_proxy *
In file included from /usr/include/pipewire-0.3/pipewire/pipewire.h:30,
                 from /<<PKGBUILDDIR>>/src/audio/pipewire/SDL_pipewire.h:28,
                 from /<<PKGBUILDDIR>>/src/audio/pipewire/SDL_pipewire.c:29:
/usr/include/pipewire-0.3/pipewire/node.h:208:58: note: expected 'struct pw_node *' but argument is of type 'struct pw_proxy *'
  208 | PW_API_NODE_IMPL int pw_node_enum_params(struct pw_node *object,
      |                                          ~~~~~~~~~~~~~~~~^~~~~~
make[2]: *** [Makefile:689: build/SDL_pipewire.lo] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 V=1 returned exit code 2
make[1]: *** [debian/rules:133: build-library] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:90: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202503/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and add an affects on src:libsdl2, so that this is still
visible in the BTS web page for this package.

Thanks.