Bug#845853: hydra: switch to build depend on the metapackage default-libmysqlclient-dev

Sun Nov 27 11:44:04 UTC 2016

On 27/11/2016 01:11, Gianfranco Costamagna wrote:
> Hi
> 
> +hydra (8.3-1.1) UNRELEASED; urgency=medium
> +
> 
> Please dch --team, don't use NMU notation
> 

hydra (8.3-2) UNRELEASED; urgency=medium


> +  * debian/control
> +    + Use default-libmysqlclient-dev instead of libmysqlclient-dev (fix #845853)
> 
> Use "Closes: #NNN" instead of fix
> 

* debian/control
    + Use default-libmysqlclient-dev instead of libmysqlclient-dev
(Closes: #845853)


> +  * debian/hydra-gtk.desktop
> +    + Remove pointless localization ("GenericName[en_GB]="  =>  "GenericName=")
> 
> Some more verbosity might be nice here
> (Why did you change that? Lintian? Desktop file validate tool?
> 
> I don't think there is need to have many uploaders, we should be able to team upload when needed.
> 

  * debian/hydra-gtk.desktop
    + Remove pointless localization ("GenericName[en_GB]="  =>
"GenericName=").
      The file does not contain multiple localization options but it
only contains
      en_GB, it usually happens when a launcher is modified through the
gnome/mate
      launcher editor, that adds the current localization string to the
modified parts
      and may cause unwanted behaviors on machines with a different
locale setup.


(no other localizations are available in that file, then to have an
option available only under en_GB is not a great idea, i am not sure if
it can cause an unwanted behavior, but i do not see it as a clean situation)


> Please check the above, finalize and I'll probably upload shortly after.
> 
> Thanks!
> 
> G.
> (Sorry for top posting, on mobile right now)
> --------------------------------------------
> Dom 27/11/16, Lorenzo "Palinuro" Faletra <palinuro at parrotsec.org> ha scritto:
> 
>  Oggetto: Re: Bug#845853: hydra: switch to build depend on the metapackage default-libmysqlclient-dev
>  A: otto at debian.org, 845853-maintonly at bugs.debian.org
>  Cc: pkg-security-team at lists.alioth.debian.org
>  Data: Domenica 27 novembre 2016, 00:44
>  
>  Hello, i have fixed it
>  and proposed my commit on
>  https://anonscm.debian.org/cgit/pkg-security/hydra.git/commit/?id=382d75da0365fb3e21cbf8f0038ecb980ae3023d
>  
>  the change is still tagged as
>  UNRELEASED, waiting for an uploader to
>  give
>  it the final dch or accept me as a new uploader
>  
>  On 26/11/2016 23:07, otto at debian.org
>  wrote:
>  > Package: hydra
>  > Severity: important
>  >
>  
>  > Hi! 
>  > 
>  > This package build depends on
>  libmysqlclient-dev. It should instead
>  >
>  build-depend on default-libmysqlclient-dev metapackage, and
>  end up
>  > having the run-time dependency
>  of the libmysqlclient implementation
>  >
>  Debian has chosen to use, currently MariaDB instead of
>  Oracle MySQL. 
>  > 
>  >
>  Announcement of new default-mysql-* metapackages:
>  > https://lists.debian.org/debian-devel-announce/2016/09/msg00000.html
>  
>  > 
>  > Wiki: https://wiki.debian.org/Teams/MySQL/default-mysql-server
>  
>  > 
>  > MBF: https://lists.debian.org/debian-devel/2016/11/msg00832.html
>  
>  > 
>  > Please
>  update the depencies accordingly. In most cases the
>  required
>  > change is: 
>  > 
>  > * BEFORE:
>  Build-Depends: libmysqlclient-dev 
>  > 
>  > * AFTER: Build-Depends:
>  default-libmysqlclient-dev 
>  > 
>  > Thanks, 
>  > 
>  > Otto 
>  > 
>  
>  -- 
>  ----
>  Lorenzo "Palinuro" Faletra
>  
>  Frozenbox Network
>  Parrot Security
>  
>  GPG ID: F4C6B9A4
>  GPG
>  FINGERPRINT: B350 5059 3C2F 7656 40E6  DDDB 97CA A129 F4C6
>  B9A4
>  
>  GPG Info: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x97CAA129F4C6B9A4
>  GPG Key: http://pgp.mit.edu/pks/lookup?op=get&search=0x97CAA129F4C6B9A4
>  
>  
>  
> 
> 

-- 
----
Lorenzo "Palinuro" Faletra

Frozenbox Network
Parrot Security

GPG ID: F4C6B9A4
GPG FINGERPRINT: B350 5059 3C2F 7656 40E6  DDDB 97CA A129 F4C6 B9A4

GPG Info: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x97CAA129F4C6B9A4
GPG Key: http://pgp.mit.edu/pks/lookup?op=get&search=0x97CAA129F4C6B9A4