[pkg] dirb package ready

[Raphael Hertzog]

Hello Philippe,

On Thu, 15 Jun 2017, Philippe Thierry wrote:
> I've imported dirb kali package and cleaned it to be compliant to Debian quality requirements.
> I've pushed the git repo in pkg-security, the ITP has been created :)

My comments:

- since you use debhelper compat 10, you don't need to build-depend on
  dh-autoreconf (debhelper already does it for you) and you don't have to
  pass "--with autoreconf" in debian/rules either (again it's implicit
  already)

- in debian/rules, you have "export DEB_BUILD_HARDENING=1", what is it
  for? I don't think anything is using that variable. It might have been
  used by hardening-wrapper in the past but it's not needed for
  dpkg-buildflags.

- again in debian/rules, you don't need the following 3 lines:
# see EXAMPLES in dpkg-buildflags(1) and read /usr/share/dpkg/*
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/default.mk

  debhelper is already setting the build flags as appropriate in the
  dh_auto_configure and dh_auto_build commands. And you are not using
  the variables exported by /usr/share/dpkg/default.mk anywhere else.

- the debian/orig-tar.sh debian/orig-tar.exclude is only a complicated
  way to do what we can do nowadays by adding a "Files-Excluded" field
  in debian/copyright (see man uscan and man mk-origtargz)

  => however this debian/watch file shows you how you can a hook a script
  into uscan and thus handle the "git submodule" problem you have with
  wcc...

- in debian/control you have "Priority: extra". We rarely use "extra".
  "optional" should be the default. extra is for limited cases, see
  https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities

- I pushed some English improvements to the description

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/