[pkg] CurveDNS - review

Lukas Schwaighofer lukas at schwaighofer.name
Sun Jun 25 22:04:38 UTC 2017


Hi Stéphane,

I'm planning to do a full review on Tuesday evening.  I've done a test
built right now, ran lintian and noticed:

* Your Makefile does not apply the C proprocessor flags $(CPPFLAGS).
  In your case that means each of the compile commands starting with
      $(CC) $(CFLAGS)
  should instead start with
      $(CC) $(CPPFLAGS) $(CFLAGS)
* debian/control
  - Depends: debonf can be dropped (inserted into ${misc:Depends} by
    dh_installdebconf)
  - The most current Standards version is now 4.0.0.  You can use the
    update checklist [1] to help you identify if any changes are
    necessary.
* rename templates to curvedns.templates for consistency (missed that
  one previously)
* run `debconf-updatepo` and commit after you change curvedns.templates
  (it's currently outdated)

Good evening
Lukas

[1] https://www.debian.org/doc/debian-policy/upgrading-checklist.html#s-4.0.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170626/b8d1b0ce/attachment.sig>


More information about the Pkg-security-team mailing list