[pkg-sec] Help with CFLAGS/LDFLAGS on t50

[Samuel Henrique]

Hi all, and sorry for the delay.

I would like to send an email telling about the upload i've made before
someone noticed, but i got caught up in some other tasks, sorry for that.

As Lukas already explained, we definitely still need an CFLAGS patch,
upstream made some changes (some were PR'ed by me), but we still need it.

So i went ahead and uploaded 5.6.13-1 (my first sponsored upload \o/), and
then we got an RC bug of FTBFS on I386, which i fixed and sent upstream[1],
i thought it would be better to release
5.6.13-2 just containing the fix to the RC bug and use -3 to remove -DNDEBUG
(actually, i forgot to remove it on -2, sorry). I did search about this
flag previously but couldn't find this old discussion on debian-devel you
mentioned, i highly appreciate if you could send me the link to that :).

Oh, and by the way, we are removing -fno-stack-protector since the first
release on debian, so this shouldn't be a problem.

I think we need to wait upstream to ack PRs 20 and 21 as they should
trigger a new release, them we can pass along the removal of the -DNDEBUG
flag on 5.6.14-1.

Thanks everyone for the attention and help!

[1]https://github.com/fredericopissarra/t50/pull/21

Samuel Henrique <samueloph>

2017-06-24 9:38 GMT-03:00 Lukas Schwaighofer <lukas at schwaighofer.name>:

> Hi Samuel,
>
> I see you have updated the flags and uploaded.  I did some more
> search regarding -DNDEBUG and found an old discussion from debian-devel
> where there seemed to be consensus that the use of it is considered
> harmful… so we might consider dropping that too in the future.
>
>
> In any case, I've tried to fix our problems with the build system
> upstream and created a pull request just now:
> https://github.com/fredericopissarra/t50/pull/20
>
> If it gets merged it will fix all our problems and we can drop the
> patch :) .
>
> Regards
> Lukas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170625/169760b5/attachment.html>