Debian pkg

[Lukas Schwaighofer]

On Tue, 6 Feb 2018 12:50:50 +0000
GengYu Rao <zouyoo at outlook.com> wrote:

> * Sorry that I forgot the previous comments,
>   I do not much about the reason why upstream did so,
>   But there is a email that I've forgot to forward.
>   Upstream do think that the files should install there,via postinst

Ok, then you should move the examples back to /usr/share, re-add the
postinst code and explain the implications of that in README.Debian
(i.e. updated example files are not installed by default until manually
copied by the user).

> * I've submitted to the upstream about the mime.types

Good.

> >restarting the service on upgrade (if that makes sense for
> >theservice)
> 
> * well, I don't think it is good to do so, and users should restart
>   manually. Because when stopped, inetsim will write log and report
>   and users should first check the present log and report before
>   start the service again (this is what i think, some users may think
>   it should)

Ok, that makes some sense.  Might be worth a note in README.Debian as
well, as I would typically expect any daemons to restart on upgrades
unless there is a good reason not to do so.


Regarding the changes you made in git, there is a subtile flaw with what
you added to the prerm script. You added:

    if [ -x "/etc/init.d/inetsim" ]; then
      if [ -x /usr/sbin/invoke-rc.d ]; then
        invoke-rc.d inetsim stop
      else
        /etc/init.d/inetsim stop
      fi
    fi

This will cause inetsim to be stopped during upgrade, because »prerm
upgrade …« is called [1].  Also there is no need to check for the
existence invoke-rc.d, that's guaranteed to exist because the package
containing it (init-system-helpers) is an "Essential" package.  I would
suggest you instead use the code that's normally generated by debhelper
(not generated now because of `--no-start`), which is:

    if [ -x "/etc/init.d/inetsim" ] && [ "$1" = remove ]; then
      invoke-rc.d inetsim stop || exit 1
    fi

Otherwise your changes look good, thanks for keeping up the work! :)

Regards
Lukas

[1] https://wiki.debian.org/MaintainerScripts