ITP: inetsim

[Lukas Schwaighofer]

On Wed, 7 Feb 2018 04:35:59 +0000
GengYu Rao <zouyoo at outlook.com> wrote:

> Hi lukas
> 
> >    - There is quite a bit of redundancy in the copying logic: The
> >      first `cp` is a superset of many of the other `cp` commands
> > that follow  
> I found that there is some reason, the first cp will check the
> /etc/inetsim/.samples_already_copied ,and will create one if it
> doesn't exist
> if there is /etc/inetsim/.samples_already_copied, means the user is 
> upgrading
> then the script will just copy certain directories under the folder.

Doesn't really make a difference, since all these directories already
exist after the first `cp` (and there is no previous version in Debian
that misses one of those directories).

I'm still not happy about this situation, where an update to the data
installed to /usr/share/inetsim will not propagate to the user unless
they manually copy it.  This is also, in my opinion, what you should
mention in the README.Debian.

> >This will cause inetsim to be stopped during upgrade,   
> Actually, I think it must be stopped, inetsim will write the log and
> report when it is stopped If it is not stopped properly, the log and
> report of previous session may get lost.

How/why will report and log get lost?  Just stopping it and not
starting it again on upgrade doesn't seem like a good choice to me.

Regards
Lukas