ITP: inetsim

[Lukas Schwaighofer]

Hi GengYu,

On Thu, 8 Feb 2018 06:13:51 +0000
GengYu Rao <zouyoo at outlook.com> wrote:

> On Thursday, February 08, 2018 03:18 AM, Lukas Schwaighofer wrote:
> > I'm still not happy about this situation, where an update to the
> > data installed to /usr/share/inetsim will not propagate to the user
> > unless they manually copy it.  This is also, in my opinion, what
> > you should mention in the README.Debian.  
> yeah, mentioned in README.Debian and the man page was patched by
> upstream the man page now says the data dir is  /var/lib/inetsim/.

Your README.Debian says:
  If you want to use your own sample files, you should move them
  to /var/lib/inetsim/ manually
Having to install your own samples but hand is not surprising.  However,
what I think you should say is: New samples in updated versions of
the inetsim package will *not* be automatically installed unless
manually done by the user.  Because that is what we are doing with the
logic of your postinst script, and this will indeed be surprising to
users.

Btw, you should break the lines in README.Debian at 80 characters to be
more terminal friendly :) .


> > How/why will report and log get lost?  Just stopping it and not
> > starting it again on upgrade doesn't seem like a good choice to
> > me.  
> when it got a SIGTERM it will write the report and log to the hard
> disk and exit.
> It may went wrong if it is not stopped before upgrade, so it need to
> be stopped and the log and report will then be saved.

Are you sure it can go wrong?  Does it runtime depend on files that you
replace during upgrade?  Unless it does that can't go wrong (the binary
is already loaded into memory and won't notice that the underlying file
changes).


Regarding try-restart:  You don't have to implement it if you don't want
to restart the daemon during upgrade.  In case you want to implement
it, use `start-stop-daemon` to determine whether the daemon is currently
running; just checking that the pid file exists is not a very good
check.

Regards
Lukas