[Pkg-shadow-commits] r2786 - in upstream/trunk: . libmisc

[Nicolas FRANÇOIS]

Author: nekral-guest
Date: 2009-04-24 22:27:58 +0000 (Fri, 24 Apr 2009)
New Revision: 2786

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/libmisc/loginprompt.c
Log:
	* libmisc/loginprompt.c: Prefer snprintf to sprintf, even if a
	small context indicates no issues.


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2009-04-24 22:27:09 UTC (rev 2785)
+++ upstream/trunk/ChangeLog	2009-04-24 22:27:58 UTC (rev 2786)
@@ -1,5 +1,10 @@
 2009-04-25  Nicolas François  <nicolas.francois at centraliens.net>
 
+	* libmisc/loginprompt.c: Prefer snprintf to sprintf, even if a
+	small context indicates no issues.
+
+2009-04-25  Nicolas François  <nicolas.francois at centraliens.net>
+
 	* src/faillog.c: Remove function calls from within assert().
 
 2009-04-25  Nicolas François  <nicolas.francois at centraliens.net>

Modified: upstream/trunk/libmisc/loginprompt.c
===================================================================
--- upstream/trunk/libmisc/loginprompt.c	2009-04-24 22:27:09 UTC (rev 2785)
+++ upstream/trunk/libmisc/loginprompt.c	2009-04-24 22:27:58 UTC (rev 2786)
@@ -156,8 +156,9 @@
 			if (strchr (nvar, '=') != NULL) {
 				envp[envc] = nvar;
 			} else {
-				envp[envc] = xmalloc (strlen (nvar) + 32);
-				sprintf (envp[envc], "L%d=%s", count++, nvar);
+				size_t len = strlen (nvar) + 32;
+				envp[envc] = xmalloc (len);
+				snprintf (envp[envc], len, "L%d=%s", count++, nvar);
 			}
 		}
 		set_env (envc, envp);