[Pkg-shadow-commits] r3089 - in upstream/trunk: . src

Nicolas FRANÇOIS nekral-guest at alioth.debian.org
Sun Jan 24 17:13:41 UTC 2010


Author: nekral-guest
Date: 2010-01-24 17:13:40 +0000 (Sun, 24 Jan 2010)
New Revision: 3089

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/src/su.c
Log:
	* src/su.c: Do not sanitize the environment. This breaks
	--preserve-environment. This sanitation was disabled on Debian
	since quite some time with no reported issues, and sanitize_env()
	documentation agrees that it should be useless as all modern
	Unixes will handle setuid executables properly. This Fixes
	Alioth#312287.


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2010-01-24 17:05:37 UTC (rev 3088)
+++ upstream/trunk/ChangeLog	2010-01-24 17:13:40 UTC (rev 3089)
@@ -1,5 +1,14 @@
 2009-01-24  Nicolas François  <nicolas.francois at centraliens.net>
 
+	* src/su.c: Do not sanitize the environment. This breaks
+	--preserve-environment. This sanitation was disabled on Debian
+	since quite some time with no reported issues, and sanitize_env()
+	documentation agrees that it should be useless as all modern
+	Unixes will handle setuid executables properly. This Fixes
+	Alioth#312287.
+
+2009-01-24  Nicolas François  <nicolas.francois at centraliens.net>
+
 	* libmisc/setupenv.c: Fix typo from 2009-11-01.
 
 2009-01-24  Paweł Hajdan, Jr.  <phajdan.jr at gentoo.org>

Modified: upstream/trunk/src/su.c
===================================================================
--- upstream/trunk/src/su.c	2010-01-24 17:05:37 UTC (rev 3088)
+++ upstream/trunk/src/su.c	2010-01-24 17:13:40 UTC (rev 3089)
@@ -409,8 +409,6 @@
 #endif
 #endif				/* !USE_PAM */
 
-	sanitize_env ();
-
 	(void) setlocale (LC_ALL, "");
 	(void) bindtextdomain (PACKAGE, LOCALEDIR);
 	(void) textdomain (PACKAGE);




More information about the Pkg-shadow-commits mailing list