[Pkg-shadow-devel] Bug#112213: marked as done ('newusers' fails to update expiry when modifying existing user's password)

Debian Bug Tracking System owner@bugs.debian.org
Mon, 04 Apr 2005 23:18:22 -0700


Your message dated Mon, 4 Apr 2005 23:14:33 +0200
with message-id <20050404211433.GM6906@mykerinos.kheops.frmug.org>
and subject line This bug is not in shadow anymore
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Sep 2001 07:17:58 +0000
>From grahame@ucs.uwa.edu.au Fri Sep 14 02:17:58 2001
Return-path: <grahame@ucs.uwa.edu.au>
Received: from typhaon.ucs.uwa.edu.au [130.95.128.64] (qmailr)
	by master.debian.org with smtp (Exim 3.12 1 (Debian))
	id 15hnEb-00044B-00; Fri, 14 Sep 2001 02:17:57 -0500
Received: (qmail 29209 invoked from network); 14 Sep 2001 07:17:52 -0000
Received: from localhost (grahame@127.0.0.1)
  by localhost with SMTP; 14 Sep 2001 07:17:52 -0000
Subject: 'newusers' fails to update expiry when modifying existing user's
	password
From: Grahame Bowland <grahame@ucs.uwa.edu.au>
To: submit@bugs.debian.org
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Evolution/0.12 (Preview Release)
Date: 14 Sep 2001 15:17:52 +0800
Message-Id: <1000451872.27478.41.camel@typhaon>
Mime-Version: 1.0
Delivered-To: submit@bugs.debian.org

Package: passwd
Version: 19990827

When modifying an existing user's password, the 'newusers' command fails
to update that user's expiry information if shadow passwords are turned
on.

Example command sent to newusers:
echo 'gbowland:sillypass:::::' | newpass

This problem emerges when using the 'poppassd' to update passwords, as
it calls the 'newusers' command in exactly this way.

A suggested patch:

---
/usr/users/g/gbowland/debian.orig/shadow-19990827/shadow-19990827/src/newusers.c    Tue Jun  8 00:40:45 1999
+++ newusers.c  Fri Sep 14 15:16:27 2001
@@ -289,6 +289,11 @@
        if ((sp = spw_locate (pwd->pw_name))) {
                spent = *sp;
                spent.sp_pwdp = pw_encrypt(passwd, crypt_make_salt());
+           spent.sp_lstchg = time((time_t *) 0) / SCALE;
+               spent.sp_min = getdef_num("PASS_MIN_DAYS", 0);
+               /* 10000 is infinity this week */
+               spent.sp_max = getdef_num("PASS_MAX_DAYS", 10000);
+               spent.sp_warn = getdef_num("PASS_WARN_AGE", -1);
                return ! spw_update (&spent);
        }




---------------------------------------
Received: (at 112213-done) by bugs.debian.org; 5 Apr 2005 06:09:37 +0000
>From bubulle@kheops.frmug.org Mon Apr 04 23:09:37 2005
Return-path: <bubulle@kheops.frmug.org>
Received: from perrier.eu.org (kheops.perrier.eu.org) [81.56.227.253] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DIhFo-0006fW-00; Mon, 04 Apr 2005 23:09:37 -0700
Received: from localhost (localhost [127.0.0.1])
	by kheops.perrier.eu.org (Postfix) with ESMTP id 1E6E64F94D
	for <112213-done@bugs.debian.org>; Mon,  4 Apr 2005 23:14:34 +0200 (CEST)
Received: from kheops.perrier.eu.org ([127.0.0.1])
	by localhost (kheops [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 01446-02 for <112213-done@bugs.debian.org>;
	Mon, 4 Apr 2005 23:14:33 +0200 (CEST)
Received: from mykerinos.kheops.frmug.org (mykerinos.kheops.frmug.org [192.168.1.3])
	by kheops.perrier.eu.org (Postfix) with ESMTP id 7E77A4F8B6
	for <112213-done@bugs.debian.org>; Mon,  4 Apr 2005 23:14:33 +0200 (CEST)
Received: by mykerinos.kheops.frmug.org (Postfix, from userid 7426)
	id 338B823272; Mon,  4 Apr 2005 23:14:33 +0200 (CEST)
Date: Mon, 4 Apr 2005 23:14:33 +0200
From: Christian Perrier <bubulle@debian.org>
To: 112213-done@bugs.debian.org
Subject: This bug is not in shadow anymore
Message-ID: <20050404211433.GM6906@mykerinos.kheops.frmug.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-message-flag: Outlook is a good virus spreading tool. It can send mail, too.
X-pot_a_miel: honeypot@kheops.frmug.org
User-Agent: Mutt/1.5.8i
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at kheops.frmug.org
Delivered-To: 112213-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=BAYES_00,VALID_BTS_CONTROL 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

tags 112213 -confirmed -patch
tags 112213 unreproducible
thanks


Trying to reproduce this bug:

root@cc-mykerinos:~# grep tintin /etc/passwd
tintin:x:1000:100:5:5:/bin/bash
root@cc-mykerinos:~# echo tintin:toto::::7: | newusers
root@cc-mykerinos:~# grep tintin /etc/passwd
tintin:x:1000:100:5:7:/bin/bash


So, this bug is obviously not here, if it has ever been here. This
should have been investigated a long time ago....:-(


--