[Pkg-shadow-devel] Bug#242407: marked as forwarded (vipw race condition)

[Debian Bug Tracking System]

Your message dated Thu, 14 Apr 2005 01:35:36 +0300
with message-id <20050413223535.GA29006@cherokee.kiev.ua>
has caused the Debian Bug report #242407,
regarding vipw race condition
to be marked as having been forwarded to the upstream software
author(s) Tomasz Kłoczko <kloczek@zie.pg.gda.pl>.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---------------------------------------
Received: (at 242407-forwarded) by bugs.debian.org; 13 Apr 2005 22:34:29 +0000
>From arg@online.com.ua Wed Apr 13 15:34:28 2005
Return-path: <arg@online.com.ua>
Received: from cluster2.uol.ua (cluster1.uol.ua) [195.123.61.210] (root)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DLqRI-0005uY-00; Wed, 13 Apr 2005 15:34:28 -0700
Received: from [194.242.119.36] (account arg@online.com.ua HELO localhost)
  by cluster1.uol.ua ( Ukraine Online SMTP 4.2.8)
  with ESMTP-TLS id 17670762; Thu, 14 Apr 2005 01:49:13 +0300
Date: Thu, 14 Apr 2005 01:35:36 +0300
From: Alexander Gattin <arg@online.com.ua>
To: Tomasz =?utf-8?Q?K=C5=82oczko?= <kloczek@zie.pg.gda.pl>
Cc: 242407@bugs.debian.org, 242407-forwarded@bugs.debian.org,
	242407-submitter@bugs.debian.org
Subject: vipw race condition
Message-ID: <20050413223535.GA29006@cherokee.kiev.ua>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="7JfCtLOvnd9MIVvH"
Content-Disposition: inline
Delivered-To: 242407-forwarded@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 
X-CrossAssassin-Score: 3


--7JfCtLOvnd9MIVvH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

tags confirmed patch
thanks

Hi!

Please, Tomasz, look into this bugreport:
  http://bugs.debian.org/242407
I checked it -- the race is really there.

I think the fix is trivial, the patch against your CVS
version is attached (I have already compiled/checked
it on my system). If I didn't miss something obvious,
evrything is fine with the proposed change.

-- 
WBR,
xrgtn

--7JfCtLOvnd9MIVvH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="vipw.diff"

--- vipw.c.orig	2005-04-14 01:20:38.000000000 +0300
+++ vipw.c	2005-04-14 01:20:54.000000000 +0300
@@ -93,10 +93,10 @@
 {
 	int err = errno;
 
-	if (filelocked)
-		(*unlock) ();
 	if (createedit)
 		unlink (fileeditname);
+	if (filelocked)
+		(*unlock) ();
 	if (msg)
 		fprintf (stderr, "%s: %s", progname, msg);
 	if (syserr)

--7JfCtLOvnd9MIVvH--