Bug#163635: [Pkg-shadow-devel] Bug#163635: Advice about this bug report

[Christian Perrier]

> Fix me if I'm wrong.
> Correct solution will be remove CLOSE_SESSION conditions and use this code
> uncondionaly if shadow was configured with PAM enabled (?)


Hmm, well, I'm not sure anyone suggested such a drastic change. This
could be likely to inadvertently change some behaviour here or there.

Keeping the code which uses CLOSE_SESSION seems sane to me.

Changing the default behaviour is a decision for you, as upstream,
taking care of all places (distros, other Unices) which use your
software, to be sure that changing the default behaviour does not
break things.

For instance, if some distro does not ship "sane defaults" as a
default login.defs file, it will be silently affected if you change
the behaviour, default or not.

So, IMHO, what's suggested here is just changing the defaults settings
shipped with Debian. This is what I have mentioned to agree with after
looking at Bastian and Alexander comments (thanks, fellows).

I would not recommend changing upstream behaviour without deep
care...but, well, you are upstream, not me..:-)