[Pkg-shadow-devel] Diff from Debian 4.0.3 to 4.0.11.1

[Nicolas François]

Hello,

(Tomasz, can you have a look at the attachment. Some parts may not be
very clear, and some issues may be only Debian specific. Just ask. Also
ask for an experimental archive if you could not connect to the anonymous
svn (this port is sometimes filtered). I can make a daily snapshot if you
wish).



That's it! I've finished reading the nearly half a million lines (424563)
of diff between 4.0.3 and 4.0.11.1.

(Well, in fact the number of lines was greatly reduced by ignoring the man
pages, the POs and some autogenerated files.)

I will commit a file in the experimental branch, with the list of (nearly)
all files and some comments about their diff (do I think it is OK,
should it be checked another time, and also when I think it is OK what is
the rational of the change (it may help for a review of a 4.0.12 diff, you
can use it to review my reviewing, and you can use it for your own
review))

As my shadow TODO list is empty^Wdeleted, I will commit a new one to the
experimental branch.


Best regards,
-- 
Nekral
-------------- next part --------------
lib/Makefile.am
    The line:
        # sources for dbm support (not yet used)
    should be removed. (in fact maybe the wrong line was removed)

lib/pwauth.c
    still use SKEY. Is SKEY support working?
    "(Echo on)" not translated. Is it normal?

src/chage.c
    two pam_start. One part seems to have been cut and pasted.

src/chfn.c
    the string:
        printf ("\t%s: %s\n", _("Room Number"), roomno);
    is not OK for the French translation (in French, we add a space before
    the colon.
        printf (_("\tRoom Number: %s\n"), roomno);
    is prefered

src/chpasswd.c
    missing:
        nscd_flush_cache ("shadow");
    NOTE: I only have a little idea of what nscd_flush_cache is. So all
          these entries about nscd_flush_cache may be wrong.
          Also (just to be sure) it is related to the libc, and gshadow
          can't be flushed?

src/chsh.c
    There used to be some authentification. When compiled with PAM, I'm not
    sure ther will be any password requested?
    Is this right?

src/groupadd.c
    some options are missing in the Usage
    OPENLOG twice

src/lastlog.c
    maybe another time_t size correction is needed
    The files are open before the options are parsed. -h won't work if the
    files can't be open. 5this is just a note, I'm not sure it is a problem)

src/pwck.c
src/pwconv.c
    missing nscd_flush_cache for passwd and shadow?

src/useradd.c
    s/the the/the/
    missing nscd_flush_cache for shadow?

src/userdel.c
src/usermod.c
    missing nscd_flush_cache for shadow?