[Pkg-shadow-devel] cdbs and questions

[Christian Perrier]

(quick telegraphic style answering....I'm just back and finally back now)

Quoting Christine Spang (spangarang at twcny.rr.com):
> OK - I've finally gotten around to (almost) finishing the port to cdbs.
> (As to Martin's concerns from earlier: I don't mind helping in whatever
> way I can if issues crop up with cdbs, though this may not be much. In
> what way is it 'not really maintained'? It seems to have an Alioth
> maintainer group, and its last upload was only a little over a month
> ago, though the upload only added documentation.)

Congratulations for that nice work (even if I didn't review it, it's
probably nice work...).



> 
> I've committed a new patch that makes all the necessary changes in order
> to build using cdbs, so it's easy to use it or lose it with no harm
> done. Please break it, comment, suggest. (Though I seem to already have
> done #1.)

Well, your patch patches debian/rules. Logically, patches in
debian/patches should only patch upstream sources and changes to
debian/rules shgould have been commited directly in this file.

BUT, I did not intend to use cdbs immediately so, after all, having
the patch in debian/patches in a Good Thing..:-).

So, I will currently comment the patch in debian/patches/series...just
to be able to build and release 4.0.12 as is.

> 
> First: When building just the clean 4.0.12 package, both with and
> without cdbs, I get the following error when using 'su':
> 
> christine at Freyja:/var/cache/pbuilder/result$ su
> Password:
> configuration error - unknown item 'FTMP_FILE' (notify administrator)
> configuration error - unknown item 'CLOSE_SESSIONS' (notify
> administrator)
> configuration error - unknown item 'CLOSE_SESSIONS' (notify
> administrator)
> root at Freyja:/var/cache/pbuilder/result#

We'll investigate this. Thanks for reporting.


> debian/control
> 
> Added cdbs to Build-Depends. Doing so through a patch is all sorts of
> Doesn't Work (TM), so I just added it manually.

I'll temporarily remove the new Build Dependency...waiting for us to
really use cdbs.

> Extras in /usr/share/doc:
> 
> The new packages contain NEWS.gz, README, TODO, and changelog.gz in both
> login and passwd. Is there any reason that they're -not- in the previous
> packages? If so, they can easily be excluded. (Though it's a little
> redundant right now - the exact same files are going into both packages.
> Though that's the same as already happens with the Debian changelog.)

This certainly needs investigation, but these files are actually
needed in both packages. Typical when a source package produces two
binary packages which can be installed independently.

> dh_installpam
> 
> We could use this to clean up the installation of PAM files. However, I
> don't see a very clean way to use it as it now stands, and especially
> without moving all the pam files out of debian/pam.d into plain debian/.

Yep. We should use dh_installpam. Need to see this later

> 
> dh_link
> 
> I haven't done this yet, but we could probably get rid of the manual
> symlinking, with {package}.links files.

You're right ; no doubt.

> 
> Weird stuff:
> 
> Right now the build with is running ./configure -twice- for reasons
> unknown, once after running autoconf and a later 'recheck'. I suspect
> that it has something to do with cdbs + updating autoconf, etc. Will
> look into this - not sure what it's for.
> 
> Also, all the other manual installing of files in debian/ is just
> screaming 'automate me!' or 'clean me!', though this may just be me.
> Some of the above could help.

Yes, definitely. I intended to look at this mess some day. This
debian/rules file sucked..:-)


> Questions regarding the old debian/rules:
> 
> -Why is DH_COMPAT exported twice? Does this mean that the first part of
> debian/rules depends on debhelper >= 4, whereas the rest can use
> debhelper >= 3? (this doesn't seem to make sense) Was the second one
> just left in accidentally, as the comment on the first one seems to
> suggest?
> 
> -What is this for?:
> 
> ifneq ($(DEB_HOST_ARCH_OS),hurd)
> 	echo "loginpam=login (>= 970502-1), libpam-modules (>= 0.72-5)" >>
> debian/passwd.substvars
> else
> 	echo "loginpam=login, libpam-modules (>= 0.72-5)" >>
> debian/passwd.substvars
> endif

Related to a recent bug. Documented in changelog, I don't remember

> 
> Did we ever figure out the cause of all the warnings that lintian and
> linda are giving out? (Sorry if I wasn't paying attention and missed
> it.)

A lot of warnings for man pages. I need to figure out if this is a bug
in the man page checking stuff or not.


> 
> Anyway, even if we don't end up using this, I learned a lot doing the
> work, gee. :)

(/me wearing his mentoring hat....but, dammit, you don't need a mentor
anymore....have you applied to the NM process, by the way?)

Guess what: this was the point..:-)