Bug#249372: [Pkg-shadow-devel] Bug#249372: Please enable login for GNU/Hurd

[Alexander Gattin]

--yrj/dFKFPuw6o+aM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

reopen 249372
tags 249372 moreinfo
thanks

Hi!

On Sat, Jul 09, 2005 at 11:18:21PM +0200, Michael Banck wrote:
> Hey people,
> 
> this patch got applied a while ago, which makes /bin/login being
> provided by the login package and passwd Depend on it.

Why is this a problem? shadow's passwd depended on
login since ages (1996?) on GNU/Linux.

How was it on Hurd?

> Thus,
> shadow/passwd/login is broken on Debian GNU/Hurd right now, and
> consequently postinsts trying to add users (like openssh, hurd) fail and
> thus installation of Debian GNU/Hurd is impossible right now.

Maybe you mean that build produces wrong/broken binary
for login (on Hurd)? Is this because of PAM?

It will be hard for me to test, 'cause I'm not a DD,
not amongst shadow uploaders and don't have an access
to any Hurd system currently (but can try).

Why at all I bother about this bug is because Martin
may be currently offline (he told something about being
less available during second half of summer).

Christian is currently at debconf, so if you want your
issue to be fixed quick, please describe more technical
details and I could be able to help you by
testing/preparing a patch so that when Christian will
return, he will just need to upload new shadow ASAP.

Of course, I can just revert the change (attached), but
IMHO it's not a good solution until I get more details
about a problem.

P.S. to discuss this you can also join #shadow on
freenode's IRC.

-- 
WBR,
xrgtn

--yrj/dFKFPuw6o+aM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="hurd.diff"

Index: trunk/sid/debian/control
===================================================================
--- trunk/sid/debian/control	(revision 108)
+++ trunk/sid/debian/control	(revision 109)
@@ -4,7 +4,7 @@
 Maintainer: Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>
 Standards-Version: 3.6.1.1
 Uploaders: Christian Perrier <bubulle@debian.org>, Sam Hartman <hartmans@debian.org>
-Build-Depends: autoconf, automake1.7, libtool, bzip2, gettext, libpam0g-dev [!hurd-i386], texinfo, file, debhelper (>= 4.1.16), po-debconf, libpam-runtime (>= 0.76-14),dpatch
+Build-Depends: autoconf, automake1.7, libtool, bzip2, gettext, libpam0g-dev, texinfo, file, debhelper (>= 4.1.16), po-debconf, libpam-runtime (>= 0.76-14),dpatch
 
 Package: passwd
 Architecture: any
Index: trunk/sid/debian/changelog
===================================================================
--- trunk/sid/debian/changelog	(revision 108)
+++ trunk/sid/debian/changelog	(revision 109)
@@ -3,6 +3,8 @@
   * Debian packaging fixes:
     - Add --host to config_options on cross build. Patch from NIIBE Yutaka.
       Closes: #283729
+    - Enable login for GNU/Hurd in rules. First patch from Robert Millan.
+      Closes: #249372
   * Debian specific programs fixes:
     - NONE
   * Upstream bugs not fixed in upstream releases or CVS:
Index: trunk/sid/debian/rules
===================================================================
--- trunk/sid/debian/rules	(revision 108)
+++ trunk/sid/debian/rules	(revision 109)
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 
-config_options := --disable-shared --without-libcrack --mandir=/usr/share/man
+config_options := --disable-shared --without-libcrack --mandir=/usr/share/man --with-libpam
 
 DEB_HOST_GNU_SYSTEM := $(shell dpkg-architecture -qDEB_HOST_GNU_SYSTEM)
 DEB_BUILD_GNU_TYPE = $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
@@ -9,10 +9,6 @@
   config_options += --host=$(DEB_HOST_GNU_TYPE)
 endif
 
-ifneq ($(DEB_HOST_GNU_SYSTEM),gnu)
-  config_options += --with-libpam
-endif
-
 # see /usr/share/doc/autotools-dev/README.Debian.gz
 export DEB_HOST_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
@@ -141,19 +137,11 @@
 	dh_compress
 	dh_shlibdeps
 	dh_installdebconf
-ifneq ($(DEB_HOST_GNU_SYSTEM),gnu)
 	echo "loginpam=login (>= 970502-1), libpam-modules (>= 0.72-5)" >> debian/passwd.substvars
-endif
 	dh_installdeb
-	dh_gencontrol -ppasswd
-ifneq ($(DEB_HOST_GNU_SYSTEM),gnu)
-	dh_gencontrol -plogin
-endif
+	dh_gencontrol
 	dh_md5sums
-	dh_builddeb -ppasswd
-ifneq ($(DEB_HOST_GNU_SYSTEM),gnu)
-	dh_builddeb -plogin
-endif
+	dh_builddeb
 
 binary: binary-indep binary-arch
 

--yrj/dFKFPuw6o+aM--