[Pkg-shadow-devel] Re: [Pkg-shadow-commits] r298 - trunk/debian/patches

[Nicolas François]

Hi!

On Fri, Jun 24, 2005 at 02:25:42AM +0200, Nicolas François wrote:
> On Fri, Jun 24, 2005 at 01:11:19AM +0200, Nicolas François wrote:
> > The part between dashes asks the user to delete groups in /etc/groups=
 when
> > they are not present in /etc/gshadow.
> > 
> > This was not asked by the submitter. I added this to have the same
> > behavior as when a group is in /etc/gshadow but not in /etc/group.
> > (grpck currently asks the user if he wants to remove the non-consiten=
t
> > entry from gshadow).
> > 
> > So, do you think this makes sense, or do you want me to remove this p=
art?
> > (or just warn)
> 
> After discussing with Martin, it could make more sense to propose to ad=
d
> the entry to gshadow.
> (It is the behavior that could be expected by an admin who would modify
> /etc/group but did not think about modifying gshadow.

Well, to add an entry, the patch will be larger and I will need some
utilities in lib/{sgroupio.[ch],gshadow.[ch]}.

So, Tomasz (or other), if you are interested in this patch and prefer the
user to be asked to add an entry in gshadow rather than removing an entry
in /etc/group, just ask.

For the moment, Christian's answer indicates that I can tag the bug pending,
uncomment the patch in series and let the patch as is.

Best Regards,
-- 
Nekral