[Pkg-shadow-devel] Bug#271407: marked as done (preseeding fixes (or, passwd.config hardcodes the wrong username for Joey Hess))
Debian Bug Tracking System
owner@bugs.debian.org
Wed, 23 Mar 2005 11:22:43 -0800
Your message dated Wed, 23 Mar 2005 18:39:14 +0100
with message-id <20050323173914.GE13294@mykerinos.kheops.frmug.org>
and subject line Acknowledging NMUs
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 13 Sep 2004 01:40:37 +0000
>From joey@kitenet.net Sun Sep 12 18:40:37 2004
Return-path: <joey@kitenet.net>
Received: from kitenet.net [64.62.161.42] (postfix)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1C6fpd-0002dM-00; Sun, 12 Sep 2004 18:40:37 -0700
Received: from dragon.kitenet.net (unknown [66.168.94.144])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client CN "Joey Hess", Issuer "Joey Hess" (verified OK))
by kitenet.net (Postfix) with ESMTP id E6B1917EC5
for <submit@bugs.debian.org>; Mon, 13 Sep 2004 01:40:36 +0000 (GMT)
Received: by dragon.kitenet.net (Postfix, from userid 1000)
id 336626E137; Sun, 12 Sep 2004 21:41:16 -0400 (EDT)
Date: Sun, 12 Sep 2004 21:41:16 -0400
From: Joey Hess <joeyh@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: preseeding fixes (or, passwd.config hardcodes the wrong username for Joey Hess)
Message-ID: <20040913014116.GA3315@kitenet.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="2B/JsCI69OhZNC5r"
Content-Disposition: inline
X-Reportbug-Version: 2.64
User-Agent: Mutt/1.5.6+20040818i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--2B/JsCI69OhZNC5r
Content-Type: multipart/mixed; boundary="AhhlLboLdkugWU4S"
Content-Disposition: inline
--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: passwd
Version: 1:4.0.3-30
Severity: normal
Tags: patch
I've been working on allowing debian installs to be automated by debconf
database preseeding. The problem I ran into with passwd is that even if
I preseeded passwd/username to "joey", it would look at my
passwd/user-fullname of "Joey Hess" and reset the default value to
"joeyh".
(Nice hardcoding of my username, but you choose the wrong one, BTW. ;-)
The attached patch fixes that as well as some issues that made it
impossible to preseed a root password. Preseeding a root password is of
dubious security, but it's _very_ useful when you're using preseeding to
do automated regression testing of full Debian installs. I think this
use of it outweighs the possibility of someone doing something stupid
security-wise, and I don't belive it opens any potential exploits.
I'd appreciate seeing these fixes in sarge, but that's up to you.
--=20
see shy jo
--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
--- old/shadow-4.0.3/debian/passwd.config 2004-09-12 21:29:23.000000000 -0400
+++ shadow-4.0.3/debian/passwd.config 2004-09-12 21:13:04.000000000 -0400
@@ -146,11 +146,6 @@
3)
# Prompt for a root password if there is none.
if ! root_password; then
- db_set passwd/root-password ""
- db_fset passwd/root-password seen false
- db_set passwd/root-password-again ""
- db_fset passwd/root-password-again seen false
-
db_input critical passwd/root-password || true
# Note that this runs at a slightly lower
# priority, so it may not always be seen. If
@@ -213,22 +208,22 @@
db_get passwd/make-user
if [ "$RET" = true ] && ! is_system_user; then
LOOP=""
- db_get passwd/user-fullname
- # Login defaults to user's first name
- # Some hat off to a few d-i people
- case "$RET" in
- "Martin Michlmayr")
- userdefault="tbm"
- ;;
- "Joey Hess")
- userdefault="joeyh"
- ;;
- *)
- userdefault="$(echo $RET | sed 's/ .*//' | tr A-Z a-z)"
- ;;
- esac
- if test -n "$userdefault"; then
- db_set passwd/username "$userdefault"
+ db_get passwd/username
+ if [ -z "$RET" ]; then
+ db_get passwd/user-fullname
+ # Login defaults to user's first name
+ # Some hat off to a few d-i people
+ case "$RET" in
+ "Martin Michlmayr")
+ userdefault="tbm"
+ ;;
+ *)
+ userdefault="$(echo $RET | sed 's/ .*//' | tr A-Z a-z)"
+ ;;
+ esac
+ if test -n "$userdefault"; then
+ db_set passwd/username "$userdefault"
+ fi
fi
db_input critical passwd/username || true
db_input critical passwd/user-password || true
--AhhlLboLdkugWU4S--
--2B/JsCI69OhZNC5r
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFBRPq7d8HHehbQuO8RAtRlAKDSIKJ4dog2joO3TVADpT6ByPJhPwCgkzXx
g/6hVRfeczWIRhTBDloZgiQ=
=G/zc
-----END PGP SIGNATURE-----
--2B/JsCI69OhZNC5r--
---------------------------------------
Received: (at 271407-done) by bugs.debian.org; 23 Mar 2005 19:12:39 +0000
>From bubulle@kheops.frmug.org Wed Mar 23 11:12:39 2005
Return-path: <bubulle@kheops.frmug.org>
Received: from perrier.eu.org (kheops.perrier.eu.org) [81.56.227.253]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DEAtZ-0004Xm-00; Wed, 23 Mar 2005 10:47:57 -0800
Received: from localhost (localhost [127.0.0.1])
by kheops.perrier.eu.org (Postfix) with ESMTP id 7D1F14F8AB;
Wed, 23 Mar 2005 19:47:25 +0100 (CET)
Received: from kheops.perrier.eu.org ([127.0.0.1])
by localhost (kheops [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id 28665-08; Wed, 23 Mar 2005 19:47:23 +0100 (CET)
Received: from mykerinos.kheops.frmug.org (mykerinos.kheops.frmug.org [192.168.1.3])
by kheops.perrier.eu.org (Postfix) with ESMTP id 054824F8AA;
Wed, 23 Mar 2005 19:47:22 +0100 (CET)
Received: by mykerinos.kheops.frmug.org (Postfix, from userid 7426)
id CE3EB232A0; Wed, 23 Mar 2005 18:39:14 +0100 (CET)
Date: Wed, 23 Mar 2005 18:39:14 +0100
From: Christian Perrier <bubulle@debian.org>
To: 284239-done@bugs.debian.org, 283961-done@bugs.debian.org,
269907-done@bugs.debian.org, 271407-done@bugs.debian.org,
277563-done@bugs.debian.org, 141322-done@bugs.debian.org,
270168-done@bugs.debian.org, 242055-done@bugs.debian.org,
242586-done@bugs.debian.org, 242813-done@bugs.debian.org,
257700-done@bugs.debian.org, 260645-done@bugs.debian.org,
261022-done@bugs.debian.org, 261553-done@bugs.debian.org,
262928-done@bugs.debian.org, 263957-done@bugs.debian.org,
264956-done@bugs.debian.org, 268051-done@bugs.debian.org,
268151-done@bugs.debian.org, 268412-done@bugs.debian.org,
268646-done@bugs.debian.org, 269967-done@bugs.debian.org,
270083-done@bugs.debian.org, 273585-done@bugs.debian.org,
275781-done@bugs.debian.org, 277741-done@bugs.debian.org,
277751-done@bugs.debian.org, 278051-done@bugs.debian.org,
282160-done@bugs.debian.org, 282443-done@bugs.debian.org,
282580-done@bugs.debian.org, 284338-done@bugs.debian.org,
286522-done@bugs.debian.org, 288879-done@bugs.debian.org,
289837-done@bugs.debian.org, 291703-done@bugs.debian.org,
292353-done@bugs.debian.org, 293911-done@bugs.debian.org,
294330-done@bugs.debian.org, 295543-done@bugs.debian.org
Subject: Acknowledging NMUs
Message-ID: <20050323173914.GE13294@mykerinos.kheops.frmug.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-message-flag: Outlook is a good virus spreading tool. It can send mail, too.
X-pot_a_miel: honeypot@kheops.frmug.org
User-Agent: Mutt/1.5.6+20040907i
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at kheops.frmug.org
Delivered-To: 271407-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 25
Given that the shadow package maintenance team has now taken over this
package, we can know acknowledge all non-maintainer uploads which were
made during the interim period.
So, hoping I made no typo, I hereby close all these bugs
definitely. Thanks a lot to all bug reporters.
--