[Pkg-shadow-devel] Bug#271565: marked as done ([POST-SARGE] remove-shell fails when /etc/shells is missing, empty or is to be emptied)

Debian Bug Tracking System owner@bugs.debian.org
Thu, 05 May 2005 01:33:11 -0700


Your message dated Thu, 05 May 2005 04:17:26 -0400
with message-id <E1DTbXy-0007Ll-00@newraff.debian.org>
and subject line Bug#271565: fixed in shadow 1:4.0.3-32
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 13 Sep 2004 19:36:17 +0000
>From david.fox@linspireinc.com Mon Sep 13 12:36:17 2004
Return-path: <david.fox@linspireinc.com>
Received: from mail.lindows.com [130.94.123.204] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1C6wca-0007SB-00; Mon, 13 Sep 2004 12:36:16 -0700
Received: by mail.lindows.com (Postfix, from userid 8)
	id C4D3CC95BCD; Mon, 13 Sep 2004 12:36:28 -0700 (PDT)
Received: from [127.0.0.1] (unknown [207.67.194.2])by mail.lindows.com (Postfix) with ESMTPid 98AE3C95BB7; Mon, 13 Sep 2004 12:36:28 -0700 (PDT)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: David Fox <david.fox@linspireinc.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: passwd: /usr/sbin/remove-shell.sh fails when shell is not in /etc/shells
X-Mailer: reportbug 2.64
Date: Mon, 13 Sep 2004 12:35:45 -0700
Message-Id: <20040913193628.98AE3C95BB7@mail.lindows.com>
X-Lindows-Footer: yes
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: passwd
Version: 1:4.0.3-30
Severity: normal
Tags: patch

Since this script is run from the bash postrm script, which uses the
-e flag to exit on any errors, the bash upgrade fails.  I made the
following changes:

--- ./usr/sbin/remove-shell~	2004-09-07 22:13:02.000000000 -0700
+++ ./usr/sbin/remove-shell	2004-09-13 11:46:06.000000000 -0700
@@ -13,7 +13,7 @@
 
 set -o noclobber
 
-trap "rm -f $tmpfile $tmpfile2" EXIT
+trap "rm -f $tmpfile $otmpfile" EXIT
         
 if ! cat $file > $tmpfile
 then
@@ -27,7 +27,8 @@
 # this is supposed to be reliable, not pretty
 for i
 do
-	grep -v "^${i}$" $tmpfile > $otmpfile
+	# This must still succeed even if the shell is not present
+	grep -v "^${i}$" $tmpfile > $otmpfile || true
 	mv $otmpfile $tmpfile
 done
 

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.8.1
Locale: LANG=C, LC_CTYPE=C

Versions of packages passwd depends on:
ii  libc6                       2.3.2.ds1-16 GNU C Library: Shared libraries an
ii  libpam-modules              0.76-22      Pluggable Authentication Modules f
ii  libpam0g                    0.76-22      Pluggable Authentication Modules l
ii  login                       1:4.0.3-30   System login tools

-- debconf information excluded
--

This message contains information which may be confidential and privileged. Unless you are the 
addressee (or authorized to receive for the addressee), you may not use, copy or disclose to anyone 
the message or any information contained in the message. If you have received the message in error, 
please advise the sender and delete the message.  Thank you.

---------------------------------------
Received: (at 271565-close) by bugs.debian.org; 5 May 2005 08:21:15 +0000
>From katie@ftp-master.debian.org Thu May 05 01:21:15 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DTbbd-0005cn-00; Thu, 05 May 2005 01:21:13 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1DTbXy-0007Ll-00; Thu, 05 May 2005 04:17:26 -0400
From: Christian Perrier <bubulle@debian.org>
To: 271565-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#271565: fixed in shadow 1:4.0.3-32
Message-Id: <E1DTbXy-0007Ll-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Thu, 05 May 2005 04:17:26 -0400
Delivered-To: 271565-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: shadow
Source-Version: 1:4.0.3-32

We believe that the bug you reported is fixed in the latest version of
shadow, which is due to be installed in the Debian FTP archive:

login_4.0.3-32_i386.deb
  to pool/main/s/shadow/login_4.0.3-32_i386.deb
passwd_4.0.3-32_i386.deb
  to pool/main/s/shadow/passwd_4.0.3-32_i386.deb
shadow_4.0.3-32.diff.gz
  to pool/main/s/shadow/shadow_4.0.3-32.diff.gz
shadow_4.0.3-32.dsc
  to pool/main/s/shadow/shadow_4.0.3-32.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 271565@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated shadow package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  3 May 2005 11:53:12 +0200
Source: shadow
Binary: login passwd
Architecture: source i386
Version: 1:4.0.3-32
Distribution: unstable
Urgency: low
Maintainer: Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description: 
 login      - system login tools
 passwd     - change and administer password and group data
Closes: 207816 271565
Changes: 
 shadow (1:4.0.3-32) unstable; urgency=low
 .
   * Switch to dpatch for upstream patches
     This should bring more clarity to modifications
     we make to upstream sources and help integrating
     new upstream releases
     Old patches have been moved quite roughly to
     debian/patches
   * Modified debian/rules for "Calling GNU configure properly", see
     /usr/share/doc/autotools-dev/README.Debian.gz
   * Debian packaging fixes:
     - Lintian fixes:
       - Description synopsis initial capital letters removed
       - passwd now depends on debconf (>=0.5.00) as it uses the seen flag
       - add login.lintian-overrides and passwd.lintian-overrides
         files to mention setuid and setgid files and avoid lintian warning
         about them
     - debian/pam.d/login:
       - Remove the confusing comment about "nullok". Closes: #207816
     - debian/rules:
       - Add call for dh_installdirs
     - debian/passwd.dirs:
       - Added
     - debian/login.dirs:
       - Added
   * Debian specific programs fixes:
     - fixed /usr/sbin/remove-shell bug with handling of non-existing/empty
       /etc/shells file. Closes: #271565
   * GNU config automated update: config.sub (20010907 to 20050422),
     config.guess (20010904 to 20050422)
Files: 
 a441f45d7679d49d409211b431e477c3 834 base required shadow_4.0.3-32.dsc
 43aa14ba6757a3eff66e6d8587cb70ae 1323517 base required shadow_4.0.3-32.diff.gz
 dd59a67f344f599074594952759f1439 529964 base required passwd_4.0.3-32_i386.deb
 75b35cf6e12299e76d0f3364262d4e20 576354 base required login_4.0.3-32_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCeQO31OXtrMAUPS0RAnqNAKCTiipgrgsDJeDhQJfrpnS6JCisiACfWRv7
Dy87EzIfbdAcb0zybsrI6p0=
=6L5+
-----END PGP SIGNATURE-----