[Pkg-shadow-devel] Bug#293492: useradd: by default creates user with unspecified shell, this causes problems

[Martin Quinson]

--xo44VMWPx7vlQ2+2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 12, 2005 at 07:26:19AM +0200, Christian Perrier wrote:
>=20
> > I'm not sure that it's less intrusive.
>=20
> Patching useradd is *more* intrusive.

Nope. I mean, we're not speaking of the same thing. You consider the
packaging intrusivity whereas I don't care about this. I want the package
being easy and intuitive to use (where possible). I don't care whether it
asks me managing another patch. Integrating it upstream is the second step.

> > My proposal goes _along_ the upstream way to do things,
> > while another patch should first be decided whether to
> > come into 3xx or 4xx series. ;)
>=20
> I don't really want another patch for this issue. We are trying to
> minimize patches to upstream sources. So dealing with this in
> /etc/default is THE way to go.

I'm not sure I could more strongly disagree here. We want to fix the bugs,
and provide Tomasz with the good fixes we cam up with so that those bugs get
solved not only in debian, but also for the misleaded ones (hehe).

If this is a bug, it has to be solved. And Alex said that the /etc/default
have bad interactions with /etc/login.defs. So if it's possible to solve the
bug without it, even better.

And, as a conclusion, I'd like to note that if you agree with me, the fix
follows:
Index: shadow-4.0.3/src/useradd.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- shadow-4.0.3.orig/src/useradd.c	2005-05-12 11:05:27.577364326 +0200
+++ shadow-4.0.3/src/useradd.c	2005-05-12 11:07:39.748616230 +0200
@@ -76,7 +76,7 @@ RCSID (PKG_VER "$Id: useradd.c,v 1.32 20
 static gid_t def_group =3D 100;
 static const char *def_gname =3D "other";
 static const char *def_home =3D "/home";
-static const char *def_shell =3D "";
+static const char *def_shell =3D "/bin/bash";
 static const char *def_template =3D SKEL_DIR;
=20
 #ifdef SHADOWPWD
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Should we discuss any further for such a simple thing?
Mt.

--xo44VMWPx7vlQ2+2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCgx1cIiC/MeFF8zQRAgAWAKC3YJ/OqfiJ610lOPaa6u/3cHVcYwCeICth
a5uF9FkBNNy3Jb4BvTk4KNI=
=5x3m
-----END PGP SIGNATURE-----

--xo44VMWPx7vlQ2+2--