[Pkg-shadow-devel] 0xx patches sorting

[Nicolas François]

On Mon, May 23, 2005 at 07:31:14AM +0200, Christian Perrier wrote:
> > What is remaining:
> >   * 006_libmisc.dpatch
> >     + failure.{c,h}
> >       I still don't see the rationale. I will check google.
> >       such patch was already applied upstream (on other files), so ma=
ybe
> >       it should be kept.
> 
> If it is already applied upstream, then just put it as 3xx and do not
> dig harder....We keep it in the transition phase and it will be there
> when we resync with upstream.

Well, this patch indicates that utmpx is used if HAVE_UTMPX_H is defined.
This is already the case upstream in *other source files*, but not in
failure.{c,h}, so I think this patch is eligible for upstream.

> >   * 008_src.dpatch
> >     + login.c
> >     + su.c
> >       these patches are quite long. It will be difficult to split the=
m,
> >       seek the rationale in the changelog, and check if applied upstr=
eam
> >       (which has a lot of changes since 4.0.3)
> 
> Yep. If you think they may be hard to dig in, you can take another
> way:
> 
> -open a 5xx series where we will put patches we consider dropping when
> syncing with upstream but indeed are unsure whether they have to be
> kept or not. We will NOT use the 5xx patches when releasing the first
> versions of 4.0.9 (or .10...) in Debian but we will have them ready in
> case they're needed.

That is a solution.
But if I have time, I would prefer to check all this on a line per line
basis (maybe one line of the patch needs to go in one of the already
separated patch).
I'm not totally lost. I have the changelog, and can get the old packages
from snapshot.debian.net to verify the patches used from one debian
release to the other.

> > Looks nice. I will be there.
> > We will see if it's too short/ambitious ;)
> > 
> > PS: you did not commit the patches for the last sarge and sid package=
s.
> 
> 
> Hmmm, you mean SVN is not synced with the released packages ?
> 
> Damn, I was sure I did it...
> 
> I'll try to find some time for doing it.
> 
> For sarge, that may be right. But sid, are you sure?

I fear both are not committed;)

But don't worry about this if you don't have time before leaving.
I can make a diff between the svn and the package (you will be able to
review the patch when you will be back).

Have a nice trip;)


BTW, I intend to attend Debconf.  We may meet there.

Kind Regards,
-- 
Nekral