Bug#249372: [Pkg-shadow-devel] Bug#249372: "Please enable login for GNU/Hurd": Can someone summarize this bug report?

[Alexander Gattin]

Hi!

On Fri, Oct 07, 2005 at 04:12:16PM +0200, Christian Perrier wrote:
> retitle 249372 Please enable login for GNU/Hurd
> thanks
> 
> I'm afraid I'm lost in this bug report: "Please enable login for
> GNU/Hurd. It was closed by a patch, then reopened...and now no-one
> seems to care about it.

Yes, it's because I don't have enough time to
experiment with my HURD.

> I'm pretty sure that the passwd/login/shadow is *not* broken on Hurd
> since July 9th...so, is there still a bug ?

Looks like the bug is still there, because as it
appears many utils from passwd can't work without
login.defs, because all calls to e.g. getdef_num() will
result in premature termination if there's no
/etc/login.defs:
> #ifndef LOGINDEFS
> #define LOGINDEFS "/etc/login.defs"
> #endif
> 
> static char def_fname[] = LOGINDEFS;	/* login config defs file       */
> static int def_loaded = 0;	/* are defs already loaded?     */
...
> int getdef_num (const char *item, int dflt)
> {
> 	struct itemdef *d;
> 
> 	if (!def_loaded)
> 		def_load ();
...
> static void def_load (void)
> {
> 	int i;
> 	FILE *fp;
> 	char buf[1024], *name, *value, *s;
> 
> 	/*
> 	 * Open the configuration definitions file.
> 	 */
> 	if ((fp = fopen (def_fname, "r")) == NULL) {
> 		SYSLOG ((LOG_CRIT, "cannot open login definitions %s [%m]",
> 			 def_fname));
> 		exit (1);

This means that e.g. useradd will fail because of
> uid_min = getdef_unum ("UID_MIN", 1000);
and the same with all other utils. What's more boring
is that a util will fail almost quietly because error is
logged through syslog (to auth.log on my system) and
there's nothing on stderr.

I think we should place login.defs in shadow-common.

-- 
WBR,
xrgtn