[Pkg-shadow-devel] Patches directory cleaning?

[Christian Perrier]

There still seems to be a few patches around which we actually don't
use:

--- /home/bubulle/tmp/patchs_here	2005-09-06 07:34:51.000000000 +0200
+++ /home/bubulle/tmp/patches_series	2005-09-06 07:34:59.000000000 +0200
@@ -1,23 +1,10 @@
 004_configure.in.dpatch
 005_manpages.dpatch
-008_login_MAXHOSTNAMELEN
 008_login_log_failure_in_FTMP
 008_su_get_PAM_username
 008_su_no_sanitize_env
 010_more-i18ned-messages
-200_de-manpages-2.dpatch
-200_de-manpages-passwd.1.dpatch
-200_de-manpages.dpatch
-201_fr-manpages.dpatch
-202_ja_manpages.dpatch
-203_pl_manpages.dpatch
-204_pt_BR-manpages.dpatch
-205_it-manpages.dpatch
-206_ko-manpages.dpatch
-207_id-manpages
-319_time_structures.dpatch
 333_shadow.5-typo_312430
-336_chfn.1
 357_newgrp-stop_cont-proxy
 365_PAM_copy_environ_later
 401_cppw_src.dpatch
@@ -28,7 +15,6 @@
 407_32char_grnames.dpatch
 421_login.1_pishing
 423_su_arguments_are_concatenated
-423_su_pass_args_without_concatenation
 424_pwck.8_quiet_option
 426_grpck_group-gshadow_members_consistency
 427_chage_expiry_0
@@ -58,5 +44,3 @@
 448_enable_man
 449_comment_missplaced
 450_shadowconfig.8
-999-2_build_using_cdbs

The 2xx series is kept for the future as it seems that our man pages
translations are currently not being used upstream. However, they
clutter up the Debian diff a *lot*.

I suggest moving them in a special directory in the SVN, just to make
the diff lighter.

008_login_MAXHOSTNAMELEN is marked "It should probably be dropped". As
Nicolas worte, the MAXHOSTNAMELEN is never used.

319_time_structures.dpatch seems to still need investigation. Parts
are applied, parts aren't.

336_chfn.1 reads "Goal: do not advertize that the "other" field can
contain control characters." and "The reason why this sentence was
commented is not clear.  We can keep the patch, without applying it."

I think we should completely drop it.

423_su_pass_args_without_concatenation is what we applied in early
July, which broke pbuilder. It has been agreed that applying it needs
deeper testing because it's very likely to break current (maybe
inadequate) use of su.

I think we need to apply this AFTER we have synced with 4.0.13 in
unstable, and do it with a special release which we will upload in
experimental.

999-2_build_using_cdbs is Christine's work on debian/rules. I suggest
we apply this on an special unstable release following the 4.0.13-1 release in
unstable.

In short, as a conclusion, the patches directory is clean. Good job,
as usual, Nicolas.

--