[Pkg-shadow-devel] Re: [Pkg-shadow-commits] r773 - trunk/debian

[Alexander Gattin]

Hi!

On Sat, Jan 07, 2006 at 06:26:06PM +0000, Christian Perrier wrote:
> +  * The "Pont-L'Évêque" release

Every time I forgot to express my happiness about you
using utf-8 for naming these in our changelog :)))

P.S. BTW we celebrate orthodox Christmas here. %)

I'm making a debuglogging patch right now -- your
commits were kind of unexpected for me.

I think it's worth to use LOG_WARN instead of LOG_DEBUG
in 3 added SYSLOG statements -- these statements are
hit only when there's an error with chown_tty().

Moreover, only one added statement will get to syslog,
as is_my_tty() immediately returns.

So instead of one LOG_WARN message user will get 2 when
hit by the bug.

And, finally, using LOG_DEBUG affects logfile size
considerably...

-- 
WBR,
xrgtn